Clément Foucault fclem
29 Followers · 0 Following

  • I'm pixel pusher.

  • Joined on 2014-07-09
Repositories
3
 Projects Public Activity Starred Repositories
Clément Foucault created pull request blender/blender#127566 2024-09-13 12:22:39 +02:00
Overlay-Next: Edit Mesh: Weight display
Clément Foucault approved blender/blender#127513 2024-09-13 12:19:43 +02:00
Overlay-Next: Edit text
Clément Foucault pushed to overlay-next-mesh-edit-weight at fclem/blender 2024-09-13 12:19:06 +02:00
bb606f31ed Overlay-Next: Edit Mesh: Weight display
40188f6c97 WM: suppress "Info" prints from reports when G.quiet is enabled
b8a6482a2e Unbreak build
1df3388fae GPv3: Create weights on draw for new strokes.
4fc665e4a1 GPv3: Apply Transform operator
Compare 10 commits »
Clément Foucault created branch overlay-next-mesh-edit-weight in fclem/blender 2024-09-13 12:19:06 +02:00
Clément Foucault commented on pull request blender/blender#127513 2024-09-13 11:37:02 +02:00
Overlay-Next: Edit text

Style. Please match surrounding codestyle.

Clément Foucault suggested changes for blender/blender#127513 2024-09-13 11:36:27 +02:00
Overlay-Next: Edit text
Clément Foucault commented on pull request blender/blender#127513 2024-09-13 11:36:26 +02:00
Overlay-Next: Edit text

Move it after layer.fade.draw . We don't want less important overlays to draw on top of it.

Clément Foucault commented on pull request blender/blender#127513 2024-09-13 11:36:25 +02:00
Overlay-Next: Edit text

Use resource.theme_settings instead of G_draw.block.

Clément Foucault commented on pull request blender/blender#127513 2024-09-13 11:35:17 +02:00
Overlay-Next: Edit text

I don't understand why you cannot write to depth inside the overlay_fb_draw?

Clément Foucault suggested changes for blender/blender#127514 2024-09-12 20:22:10 +02:00
EEVEE: Light & Shadow linking

Partial review

Clément Foucault commented on pull request blender/blender#127514 2024-09-12 20:22:09 +02:00
EEVEE: Light & Shadow linking

I think we mandate 2 empty lines between functions and classes in python. But can't find any reference to this. But best to follow local conventions (which do use double blank lines).

Clément Foucault commented on pull request blender/blender#127514 2024-09-12 20:22:08 +02:00
EEVEE: Light & Shadow linking

Use 24u. Otherwise some compilers give warnings.

Clément Foucault commented on pull request blender/blender#127514 2024-09-12 20:22:06 +02:00
EEVEE: Light & Shadow linking

Do not use arrays of scalars inside structures used in SSBOs or UBOs. They cause alignment issues. Prefer using uint2 here.

Clément Foucault commented on pull request blender/blender#127514 2024-09-12 20:22:05 +02:00
EEVEE: Light & Shadow linking

Use /**/ for comments.

Clément Foucault commented on pull request blender/blender#127513 2024-09-12 19:58:18 +02:00
Overlay-Next: Edit text

It is supposed to draw the Text mesh wireframe even in edit mode. But this should be done by the wireframe overlay anyway. So +1 for removing it

Clément Foucault created pull request blender/blender#127518 2024-09-12 18:11:18 +02:00
Overlay-Next: Particle Edit
Clément Foucault pushed to overlay-next-part-edit at fclem/blender 2024-09-12 18:10:47 +02:00
672d1cb909 Overlay-Next: Particle Edit
c0b1091e5b Overlay-Next: Grease Pencil Edit Mode
2f9884cee1 Refactor: Sculpt: Use int instead of PBVHVertRef in expand
367cceaab8 Anim: Make it possible to enter/exit NLA tweak mode on slotted Actions
17ddca5017 Fix #127240: Deforming motion blurred point clouds do not render under certain conditions
Compare 10 commits »
Clément Foucault created branch overlay-next-part-edit in fclem/blender 2024-09-12 18:10:46 +02:00
Clément Foucault deleted branch overlay-next-gpencil-edit from fclem/blender 2024-09-12 17:06:13 +02:00
Clément Foucault merged pull request blender/blender#127317 2024-09-12 17:06:10 +02:00
Overlay-Next: Grease Pencil Edit Mode