Falk David filedescriptor
9 Followers · 0 Following

  • Grease Pencil developer at Blender.

  • Joined on 2017-01-04
Overview Repositories
7
 Projects Public Activity Starred Repositories
1
Falk David deleted branch gpv3-insert-frames-in-multiple-layers from filedescriptor/blender 2024-09-23 12:13:21 +02:00
Falk David pushed to main at blender/blender 2024-09-23 12:13:18 +02:00
332f7517da GPv3: Add function to insert a keyframe into multiple layers
Falk David merged pull request blender/blender#127930 2024-09-23 12:13:17 +02:00
GPv3: Add function to insert a keyframe into multiple layers
5454940b7a Cleanups
1d0ee705b8 Merge branch 'main' into gpv3-insert-frames-in-multiple-layers
3d74be9c5b Fix #126947: EEVEE: Color drifting & darkening at high sample count
ddb2179e37 Vulkan: GPU device selection
f4c8845b60 Cleanup: remove duplicate check for AMD W6800 GPU
Compare 51 commits »
Falk David commented on pull request blender/blender#120121 2024-09-23 12:02:21 +02:00
GPv3: Fill gradient tool

static

Falk David suggested changes for blender/blender#120121 2024-09-23 11:33:56 +02:00
GPv3: Fill gradient tool

Did a pass on this. Also tested the PR and it works very well, good job 👍

Falk David commented on pull request blender/blender#120121 2024-09-23 11:33:55 +02:00
GPv3: Fill gradient tool

I think it makes sense to add a separator above so that it's in a separate "category". E.g. this would be where the transform UVs/fill tool would be too.

Falk David commented on pull request blender/blender#120121 2024-09-23 11:33:54 +02:00
GPv3: Fill gradient tool

Should be something like # Grease Pencil: Texture Gradient Tool

Falk David commented on pull request blender/blender#120121 2024-09-23 11:33:53 +02:00
GPv3: Fill gradient tool

if (region->regiontype == RGN_TYPE_WINDOW && event->type == LEFTMOUSE && event->val == KM_PRESS) {

Falk David commented on pull request blender/blender#120121 2024-09-23 11:33:51 +02:00
GPv3: Fill gradient tool

"Draw a line to set the fill material gradient for the selected strokes"

Falk David commented on pull request blender/blender#120121 2024-09-23 11:33:50 +02:00
GPv3: Fill gradient tool

Maybe gradient_normal ?

Falk David commented on pull request blender/blender#120121 2024-09-23 11:33:49 +02:00
GPv3: Fill gradient tool

Maybe vector/gradient_vector ?

Falk David commented on pull request blender/blender#120121 2024-09-23 11:33:48 +02:00
GPv3: Fill gradient tool

What does sco stand for? Might be better to not abbreviate.

Falk David commented on pull request blender/blender#120121 2024-09-23 11:33:47 +02:00
GPv3: Fill gradient tool

Use grease_pencil.layer(info.layer_index).

Falk David commented on pull request blender/blender#120121 2024-09-23 11:33:45 +02:00
GPv3: Fill gradient tool

if ((ret & OPERATOR_RUNNING_MODAL) != 0 && event->type == LEFTMOUSE && event->val == KM_RELEASE) {

Falk David commented on pull request blender/blender#120121 2024-09-23 11:33:44 +02:00
GPv3: Fill gradient tool

if ((ret & OPERATOR_RUNNING_MODAL) != 0)

Falk David commented on pull request blender/blender#127999 2024-09-23 11:11:01 +02:00
GPv3: Move layer operator.

Yea that's fine. Doesn't need to be a general feature everywhere. We do implement this behavior for the dopesheet channels, so I think for GP it makes sense to have them in the properties editor too.

Falk David suggested changes for blender/blender#127999 2024-09-23 10:51:07 +02:00
GPv3: Move layer operator.

Since this is a nice quality of life improvement (drag and drop can be a bit fiddly), I don't have an issue adding this.

Falk David commented on pull request blender/blender#127999 2024-09-23 10:51:05 +02:00
GPv3: Move layer operator.

I don't think it's a good idea to change the UI this way. It's ok if the up/down arrows don't do anything if there's just one layer/group. A better option is to check in the poll function if there is at least one node. This way the buttons are grayed out, but don't pop in and out of existance.

Falk David commented on pull request blender/blender#127972 2024-09-23 10:43:47 +02:00
Fix #127968: Add label to the grease pencil overlays Panel

@blender-bot build