-
Grease Pencil developer at Blender.
- Joined on
2017-01-04 -
-
Ok I guess if it's the original comment it's fine to leave it.
Ok I think it would be better to do the simpler thing for now and use 100% opacity in process_start_sample.
How did it work in 4.2 ? If the strength in the brush setting has the pressure sensitivity on, does it do this averaging you talked about?
I think the "Default Eraser" design is subject to change (apparently this was already changed for meshes). Currently, with the design that we have, this is expected behavior (to a bug). In order…
Did a pass on this, but I think before moving further, we need regression tests for this.
Leave any functional changes out of the refactor. This can be done in another PR.
I would split this into convert_font_to_curves_legacy and convert_font_to_mesh where the latter calls convert_font_to_curves_legacy.
Maybe get_object_for_conversion ? I don't think ensure_object_duplication is what this function is doing.
I think this function should be split. The goal is to have smaller functions rather than one function that tries to do multiple things at once.
I think the opacity is set to the strength of the draw tool.
Implementation wise, I think what we should do is similar to the way the eraser can be called from the draw tool. See `get_stroke_op…
Note that the adaptive sample is the one that was ported. Not sure why the other modes of the operator were not.
Yes, this is already on our list here: blender/blender#130518
The actual radius attribute written to the curve geometry should not depend on the view at all
Yes, this is already the case for when the brush size is set to Scene (default).
The issue…