Howard Trickey howardt
  • Joined on 2011-05-01
Howard Trickey commented on pull request blender/blender#106631 2024-11-05 21:03:08 +01:00
Modifiers: Boolean Fast Mode Refactor

I'm confused by the added comment, 'bias towards shorter distances'.

It seems you are added a slight amount to both the numerator and denominator of a fraction. For positive fractions, that…

Howard Trickey suggested changes for blender/blender#106631 2024-11-01 15:05:20 +01:00
Modifiers: Boolean Fast Mode Refactor

This is going to take quite a while to review thoroughly. But after spending an hour or so, here are some comments.

Howard Trickey commented on pull request blender/blender#106631 2024-11-01 15:05:19 +01:00
Modifiers: Boolean Fast Mode Refactor

In general it would be nice if any function that does something that is not completely obvious from its name would get a comment. I had to read this one a bit carefully to understand what it was going to do.

Howard Trickey commented on pull request blender/blender#106631 2024-11-01 15:05:18 +01:00
Modifiers: Boolean Fast Mode Refactor

This comment could be more helpful to future maintainers.

Howard Trickey commented on pull request blender/blender#106631 2024-11-01 15:05:17 +01:00
Modifiers: Boolean Fast Mode Refactor

remove space between math and ::cross in previous three lines

Howard Trickey commented on pull request blender/blender#106631 2024-11-01 15:05:15 +01:00
Modifiers: Boolean Fast Mode Refactor

This comment should be updated to reflect what is supported after this update.

Howard Trickey commented on pull request blender/blender#106631 2024-11-01 13:44:42 +01:00
Modifiers: Boolean Fast Mode Refactor

Thanks for fixing the previous problem I found.

I am reviewing the code as is but noting that it doesn't properly handle cases where one operand of the boolean contains several overlapping…

Howard Trickey commented on pull request blender/blender#106631 2024-10-31 14:35:33 +01:00
Modifiers: Boolean Fast Mode Refactor

I'm starting to look at this. I made a file with a couple test cases (coplanarbool.blend, attached). The "Cube" object, having a cube with a pyramid on top, worked as expected. But the "CubeB"…

Howard Trickey deleted branch Rob-Blair-main from blender/blender 2024-10-30 15:26:21 +01:00
Howard Trickey commented on pull request blender/blender#126309 2024-10-30 13:34:34 +01:00
Fix #125024: Bevel offset - eliminate divide by 0

For the record, the commit is dd334faa5815aa52b6e1708f643efaaab6df393e

Howard Trickey closed pull request blender/blender#129586 2024-10-30 13:34:21 +01:00
Fix #125024: Bevel offset - eliminate divide by 0.
Howard Trickey commented on pull request blender/blender#129586 2024-10-30 13:34:12 +01:00
Fix #125024: Bevel offset - eliminate divide by 0.

Merged manually with author=Rob-Blair. Commit: dd334faa5815aa52b6e1708f643efaaab6df393e

Howard Trickey closed pull request blender/blender#126309 2024-10-30 13:33:04 +01:00
Fix #125024: Bevel offset - eliminate divide by 0
Howard Trickey commented on pull request blender/blender#126309 2024-10-30 13:33:01 +01:00
Fix #125024: Bevel offset - eliminate divide by 0

I committed this manually, with author=Rob-Blair, after checking in a separate PR (blender/blender#129586) that the buildbot passes the tests. I was having…

Howard Trickey pushed to main at blender/blender 2024-10-30 13:30:44 +01:00
dd334faa58 Fix #125024: Bevel offset - eliminate divide by 0.
Howard Trickey closed issue blender/blender#125024 2024-10-30 13:30:42 +01:00
Bevel Modifier creates unwanted geometries that have seemingly undefined location
Howard Trickey created pull request blender/blender#129586 2024-10-30 12:35:44 +01:00
Fix #125024: Bevel offset - eliminate divide by 0.
Howard Trickey created branch beveldiv0 in howardt/blender 2024-10-30 12:34:21 +01:00
Howard Trickey pushed to beveldiv0 at howardt/blender 2024-10-30 12:34:21 +01:00
52124007d0 Fix #125024: Bevel offset - eliminate divide by 0.
f86710b90f Cleanup: pass multiple arguments to str.startswith
160e76cd9d Cleanup: remove unused function BM_mesh_active_elem_index_get
bc02853c29 Merge branch 'blender-v4.3-release'
c5362d76ff Merge branch 'blender-v4.3-release'
Compare 10 commits »