I am so glad this landed. Thanks for your great work, Lukasz, and thanks Campbell for your help too.
We should update the Blender Manual to describe how to use this. I just had a look and the…
We think this is ready for commit, but Campbell wants to do one final review and test. Hopefully this will be committed this week.
Thanks Mike93. I am just checking that this means that I am waiting for an update from you before looking at this further. You only need reply if that's an incorrect assumption.
Hi Mike93,
The patch is now unbuildable because of the change in where libraries are. I can fix this if you like, but might be better if you merged a current main into your branch and made it…
Rather than try to modify this pull request to something that would be completely different, I just committed [8549bc94deaa]([url](https://projects.blender.org/blender/blender/commit/8549bc94deaa91…
The problem is that the code assumes that if there is more than one segment then the corner pattern will be M_TRI_FAN (for which there will be an early return) or M_ADJ (where all those mesh_vert()…
I made some minor requests for changes. I think it is ready for commit after those are addressed, but Campbell might want to look too.
This will fail if either a or b is a zero vector. Do we believe that all calls of this will guarantee non-zero length arguments? E.g., in find_vertex_to_opposite_angles_correspondence below, what if a triangle has two equal vertices?
The code below assumes neither angle1 nor angle2 is zero. What if triangles are degenerate?
The 3 here seems kind of arbitrary. How was this arrived at? Should there be some kind of user control over this?
Are we guaranteed that dblA != 0? I wonder what happens with degenerate triangles.