Campbell Barton ideasman42
  • Australia
  • Joined on 2005-01-30
Campbell Barton commented on pull request blender/blender#105821 2023-03-21 05:32:29 +01:00
UV: Add option to Pack UVs using xatlas strategy

const ?

Campbell Barton commented on pull request blender/blender#105821 2023-03-21 05:32:29 +01:00
UV: Add option to Pack UVs using xatlas strategy

*picky* prefer brackets when mixing add/subtract with multiply/divide. Bugs caused by edits that don't take order of operations into account happen from time to time, so better avoid them entirely.

Campbell Barton commented on pull request blender/blender#105821 2023-03-21 05:32:28 +01:00
UV: Add option to Pack UVs using xatlas strategy

This function should also create a Heap for BLI_polyfill_beautify in addPolygon to use to avoid re-creating the Heap for every faces with >3 vertices.

Campbell Barton commented on pull request blender/blender#105821 2023-03-21 05:32:28 +01:00
UV: Add option to Pack UVs using xatlas strategy

pass a reference?

Campbell Barton commented on pull request blender/blender#105821 2023-03-21 05:32:28 +01:00
UV: Add option to Pack UVs using xatlas strategy

Shouldn't CONCAVE_HOLE be the default? (as far as I was aware this is what users want practically all the time).

Campbell Barton commented on pull request blender/blender#105821 2023-03-21 05:32:28 +01:00
UV: Add option to Pack UVs using xatlas strategy

Names are a bit esoteric.

Campbell Barton pushed to main at blender/blender 2023-03-21 02:58:12 +01:00
f54af343f1 Merge branch 'blender-v3.5-release'
5332537fc5 Cleanup: add struct comments for GHOST/Wayland
Compare 2 commits »
Campbell Barton pushed to blender-v3.5-release at blender/blender 2023-03-21 02:57:15 +01:00
5332537fc5 Cleanup: add struct comments for GHOST/Wayland
Campbell Barton reopened issue blender/blender#104272 2023-03-21 01:57:20 +01:00
Wayland: Inverted (natural) option ignored on (resolved upstream)
Campbell Barton commented on issue blender/blender#104272 2023-03-21 01:57:18 +01:00
Wayland: Inverted (natural) option ignored on (resolved upstream)

Re-opening as the fix will only be enabled once Linux libs uses Wayland v1.22.

Campbell Barton pushed to main at blender/blender 2023-03-21 01:55:05 +01:00
5404841421 Merge branch 'blender-v3.5-release'
98272e5bb2 Fix #104272: Inverted (natural) option ignored on Wayland
Compare 2 commits »
Campbell Barton closed issue blender/blender#104272 2023-03-21 01:55:04 +01:00
Wayland: Inverted (natural) option ignored on (resolved upstream)
Campbell Barton pushed to blender-v3.5-release at blender/blender 2023-03-21 01:52:14 +01:00
98272e5bb2 Fix #104272: Inverted (natural) option ignored on Wayland
Campbell Barton pushed to main at blender/blender 2023-03-20 01:18:51 +01:00
7cda559d7c Cleanup: format, spelling, struct member comment
Campbell Barton suggested changes for blender/blender#104424 2023-03-20 01:04:00 +01:00
Mesh: Replace MLoop struct with generic attributes

Issue with layer-writing noted in reply.

Campbell Barton commented on pull request blender/blender#104424 2023-03-20 00:59:20 +01:00
Mesh: Replace MLoop struct with generic attributes

Generally seems fine - minor issues noted inline.

Testing I ran into two issues though:

  • Mesh::mloop pointer is left set after writing a file, shouldn't this be…
Campbell Barton suggested changes for blender/blender#104424 2023-03-17 10:56:24 +01:00
Mesh: Replace MLoop struct with generic attributes

Generally seems fine - minor issues noted inline.

Campbell Barton commented on pull request blender/blender#104424 2023-03-17 10:56:23 +01:00
Mesh: Replace MLoop struct with generic attributes

*picky* renames input_ to src_, a prefix which remains used elsewhere. Use input_ here too?

Campbell Barton commented on pull request blender/blender#104424 2023-03-17 10:56:23 +01:00
Mesh: Replace MLoop struct with generic attributes

*picky*: odd not to call this vert_i ? (used elsewhere).