infrastructure/archive-website
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

UI: Archive-website web-assets v2 upgrade #1

Merged
Márton Lente merged 14 commits from ui/web-assets-v2-upgrade into main 2024-08-26 17:19:01 +02:00
Conversation 1 Commits 14 Files Changed 9 +24768 -217
Márton Lente commented 2024-08-26 16:19:39 +02:00
Owner
Copy Link

This pull request upgrades Web Assets to v2 by adding pre-compiled BWA styles (as of v2.0.0-alpha.32), resolves post-upgrade issues, and makes the necessary project-specific changes.

Web Assets v2 brings UI fixes, improvements, and new development features to the platform as detailed on the Web Assets v2 guidelines and notes wiki page.

Visual changes are kept to a minimum. Some project-level cleanup has been done when converting components to use Web Assets v2 markup and styles.

Screenshot:

ui-archive-website-web-assets-v2-upgrade-sm.png

This pull request also resolves visual issues coming from the hotlinking of blender.org styles (where a major update broke the styling of sites that referenced it).

This pull request upgrades Web Assets to v2 by adding pre-compiled BWA styles (as of [v2.0.0-alpha.32](https://projects.blender.org/infrastructure/web-assets/releases/tag/v2.0.0-alpha.32)), resolves post-upgrade issues, and makes the necessary project-specific changes. Web Assets v2 brings UI fixes, improvements, and new development features to the platform as detailed on the Web Assets [v2 guidelines and notes](https://projects.blender.org/infrastructure/web-assets/wiki/v2-guidelines-and-notes.md) wiki page. Visual changes are kept to a minimum. Some project-level cleanup has been done when converting components to use Web Assets v2 markup and styles. **Screenshot:** ![ui-archive-website-web-assets-v2-upgrade-sm.png](/attachments/253f3c86-7931-4670-a0e7-6bed4f286903) This pull request also resolves visual issues coming from the hotlinking of blender.org styles (where a major update broke the styling of sites that referenced it).
ui-archive-website-web-assets-v2-upgrade-sm.png
924 KiB
Márton Lente added 13 commits 2024-08-26 16:19:40 +02:00 
Upgrade classnames and styles to web-assets v2.
v2 styling.
Change navbar-global component to use the latest component markup from
web-assets v2.
Improve cards-item-title line-height to fit modular scaling after web-assets
v2 upgrade.
Remove hotlinking stylesheet, and add compiled styles from code.blender.org,
pre-compiled with web-assets v2.0.0-alpha.30.
Set data-theme to light, to always load the site with the light colour theme.
Update statick font assets fontutti as of web-assets v2.0.0-alpha.30.
Márton Lente requested review from Pablo Vazquez 2024-08-26 16:19:54 +02:00
Pablo Vazquez approved these changes 2024-08-26 16:28:22 +02:00
Pablo Vazquez left a comment
Owner
Copy Link

Looks good!

Just noticed you are linking to v2.0.0-alpha.32 but mention v2.0.0-alpha.30. Not sure it matters but just to be consistent.

Looks good! Just noticed you are linking to `v2.0.0-alpha.32` but mention `v2.0.0-alpha.30`. Not sure it matters but just to be consistent.
index.html Outdated
@ -19,3 +19,3 @@
<meta name="twitter:description" content="Legacy versions of the Blender online infrastructure." />
<meta name="twitter:image" content="https://www.blender.org/wp-content/themes/bthree/assets/images/blender_logo_square.png" />
<link rel="stylesheet" href="https://www.blender.org/wp-content/themes/bthree/style.css?4c87a8" type="text/css" media="screen" />
<link rel="stylesheet" href="assets/css/style.css?v=2.0.0-alpha.30" type="text/css" media="screen" />
Pablo Vazquez commented 2024-08-26 16:27:57 +02:00
Owner
Copy Link

Not a biggie but isn't alpha.32 the latest release?

Not a biggie but isn't `alpha.32` the latest release?
Márton Lente added 1 commit 2024-08-26 17:07:35 +02:00 
Part of #1
Márton Lente commented 2024-08-26 17:15:14 +02:00
Author
Owner
Copy Link

@pablovazquez thanks for the feedback!

Web-assets was indeed at the slightly outdated v2.0.0-alpha.30 (that is currently in prod at code.blender.org). I re-compiled and added the latest v alpha.32. Better to have the newer one.

I'm going ahead with the merge.

@pablovazquez thanks for the feedback! Web-assets was indeed at the slightly outdated _v2.0.0-alpha.30_ (that is currently in prod at code.blender.org). I re-compiled and added the latest v _alpha.32_. Better to have the newer one. I'm going ahead with the merge.
Márton Lente merged commit 3341ac987a into main 2024-08-26 17:19:01 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Pablo Vazquez
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/archive-website#1
No description provided.
Delete Branch "ui/web-assets-v2-upgrade"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?