Support triggering buildbot when reviewing pull request #4
No reviewers
Labels
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: infrastructure/blender-bot#4
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "JacquesLucke/blender-bot:build-pr-on-review"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Note: I was not able to test this patch myself, so I'm just guessing the code changes.
The issue is that
@blender-bot build
does not work when it's part of a review (instead of a stand-alone comment). See e.g. here.I think the issue is that these kinds of reviews don't trigger a
pull_request_comment
event, but e.g.pull_request_review_approved
. I don't know what the exact payload of that event is though and whethercommands.comment_event
needs to be updated too. See this for a list of available webhooks.@bartvdbraak By just looking at the code it seems reasonable. Is it something you can deploy to UATEST, help us verify, and so on?
Checkout
From your project repository, check out a new branch and test the changes.