Support triggering buildbot when reviewing pull request #4

Open
Jacques Lucke wants to merge 1 commits from JacquesLucke/blender-bot:build-pr-on-review into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
First-time contributor

Note: I was not able to test this patch myself, so I'm just guessing the code changes.

The issue is that @blender-bot build does not work when it's part of a review (instead of a stand-alone comment). See e.g. here.

I think the issue is that these kinds of reviews don't trigger a pull_request_comment event, but e.g. pull_request_review_approved. I don't know what the exact payload of that event is though and whether commands.comment_event needs to be updated too. See this for a list of available webhooks.

Note: I was not able to test this patch myself, so I'm just guessing the code changes. The issue is that `@blender-bot build` does not work when it's part of a review (instead of a stand-alone comment). See e.g. [here](https://projects.blender.org/blender/blender/pulls/124787#issuecomment-1247788). I think the issue is that these kinds of reviews don't trigger a `pull_request_comment` event, but e.g. `pull_request_review_approved`. I don't know what the exact payload of that event is though and whether `commands.comment_event` needs to be updated too. See [this](https://github.com/go-gitea/gitea/blob/main/modules/webhook/type.go#L10) for a list of available webhooks.
Jacques Lucke added 1 commit 2024-07-22 16:45:06 +02:00
Sergey Sharybin requested review from Bart van der Braak 2024-07-22 16:47:54 +02:00

@bartvdbraak By just looking at the code it seems reasonable. Is it something you can deploy to UATEST, help us verify, and so on?

@bartvdbraak By just looking at the code it seems reasonable. Is it something you can deploy to UATEST, help us verify, and so on?
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u build-pr-on-review:JacquesLucke-build-pr-on-review
git checkout JacquesLucke-build-pr-on-review
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/blender-bot#4
No description provided.