infrastructure/blender-bot
1
3
Fork 4
Code Pull Requests 1 Activity

Update status label when reopening a report based on closed status #6

Merged
Bart van der Braak merged 4 commits from Alaska/blender-bot:reset-to-previous into main 2024-10-01 12:39:44 +02:00
Conversation 6 Commits 4 Files Changed 1 +15 -25
1 changed files with 15 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit cd01e96e82 - Show all commits

40
labels.py
View File

@ -25,7 +25,8 @@ def issues_event(data):
issue_labels = issue["labels"] issue_labels = issue["labels"]
# Ensure valid status on issue close/open. # Ensure valid status on issue close/open.
status_closed = {"Status/Archived", "Status/Resolved", "Status/Duplicate"} status_resolved = "Status/Resolved"
status_closed = {"Status/Archived", "Status/Duplicate", status_resolved}
status_prefix = "Status/" status_prefix = "Status/"
type_prefix = "Type/" type_prefix = "Type/"
@ -39,31 +40,20 @@ def issues_event(data):
else: else:
new_status = "Status/Resolved" new_status = "Status/Resolved"
elif action == "reopened": elif action == "reopened":
for label in issue_labels: # Reopen as "Needs Triage" unless the issue was "Resolved"
if label["name"].startswith(status_prefix) and label["name"] not in status_closed: # Reopening a issue after it had been set to "Resolved" means a commit
return # attempted to fix it, but didn't actually fix it and people are still
# experiencing the issue.
# Use Needs Triage as a default
new_status = "Status/Needs Triage" new_status = "Status/Needs Triage"
for label in issue_labels:
issue_timeline = utils.gitea_api_get(issue_url + "/timeline") if label["name"].startswith(status_prefix)
bartvdbraak marked this conversation as resolved Outdated
Bart van der Braak commented 2024-10-01 12:24:48 +02:00
Outdated
Review
Copy Link

Shouldn't this be:

if label["name"].startswith(status_prefix):
Shouldn't this be: ``` if label["name"].startswith(status_prefix): ```
Alaska commented 2024-10-01 12:34:42 +02:00
Outdated
Review
Copy Link

You're right, I've fixed it.

You're right, I've fixed it.
for event in issue_timeline: if label["name"] not in status_closed:
if not event["type"] == "label": # Issue was reopened and had a new status label set.
# We are only interested in events that modify labels # So skip setting a new one.
continue return
if not event["body"] == "1": if label["name"] == status_resolved:
# "body" = "1" denotes that the label was added. new_status = "Status/Confirmed"
# And we don't care about labels that were removed. break
continue
old_label_name = event["label"]["name"]
if not old_label_name.startswith(status_prefix):
# We are only interested in label events that modify `Status/` labels
continue
if old_label_name in status_closed:
# We are restoring the report to a open state, so we don't care about
# "closed" labels.
continue
new_status = old_label_name
else: else:
return return