infrastructure/blender-bot
1
3
Fork 4
Code Pull Requests 1 Activity

Update status label when reopening a report based on closed status #6

Merged
Bart van der Braak merged 4 commits from Alaska/blender-bot:reset-to-previous into main 2024-10-01 12:39:44 +02:00
Conversation 6 Commits 4 Files Changed 1 +15 -6
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
labels.py
View File

@ -25,7 +25,8 @@ def issues_event(data):
issue_labels = issue["labels"]
# Ensure valid status on issue close/open.
status_closed = {"Status/Archived", "Status/Resolved", "Status/Duplicate"}
status_resolved = "Status/Resolved"
status_closed = {"Status/Archived", "Status/Duplicate", status_resolved}
status_prefix = "Status/"
type_prefix = "Type/"
@ -39,12 +40,20 @@ def issues_event(data):
else:
new_status = "Status/Resolved"
elif action == "reopened":
for label in issue_labels:
if label["name"].startswith(status_prefix) and label["name"] not in status_closed:
return
# Set to Needs Triage
# Reopen as "Needs Triage" unless the issue was "Resolved"
# Reopening a issue after it had been set to "Resolved" means a commit
# attempted to fix it, but didn't actually fix it and people are still
# experiencing the issue.
new_status = "Status/Needs Triage"
for label in issue_labels:
if label["name"].startswith(status_prefix):
bartvdbraak marked this conversation as resolved Outdated
Bart van der Braak commented 2024-10-01 12:24:48 +02:00
Outdated
Review
Copy Link

Shouldn't this be:

if label["name"].startswith(status_prefix):
Shouldn't this be: ``` if label["name"].startswith(status_prefix): ```
Alaska commented 2024-10-01 12:34:42 +02:00
Outdated
Review
Copy Link

You're right, I've fixed it.

You're right, I've fixed it.
if label["name"] not in status_closed:
# Issue was reopened and had a new status label set.
# So skip setting a new one.
return
if label["name"] == status_resolved:
new_status = "Status/Confirmed"
break
else:
return