infrastructure/blender-buildbot-www
1
0
Fork 1
Code Issues 4 Pull Requests Projects Releases Wiki Activity

Remove the "All Archived Builds" link at the bottom of the Daily Builds archive page #12

New Issue
Closed
opened 2024-09-03 10:10:17 +02:00 by xan2622 · 4 comments
xan2622 commented 2024-09-03 10:10:17 +02:00
Copy Link

If on the Daily Builds page, the "All Archived Builds" link is necessary, it is not (necessary) at the bottom of the Daily Builds archive page.

If on the [Daily Builds page](https://builder.blender.org/download/daily/), the "All Archived Builds" link is necessary, it is not (necessary) at the bottom of the [Daily Builds archive page](https://builder.blender.org/download/daily/archive/).
xan2622 commented 2024-09-03 10:34:47 +02:00
Author
Copy Link

But also on :

But also on : - https://builder.blender.org/download/experimental/archive/ - https://builder.blender.org/download/patch/archive/ - https://builder.blender.org/download/bpy/archive/ (page currently missing, see https://projects.blender.org/infrastructure/blender-buildbot-www/issues/13)
Pablo Vazquez commented 2024-09-03 11:12:14 +02:00
Owner
Copy Link

Thanks for the suggestion. Makes sense to have an if statement around it.

Thanks for the suggestion. Makes sense to have an if statement around it.
Márton Lente was assigned by Pablo Vazquez 2024-09-03 11:12:23 +02:00
xan2622 commented 2024-10-28 16:53:36 +01:00
Author
Copy Link

Has this issue been closed by mistake?

I can still see the "All Archived Builds" link at the bottom of https://builder.blender.org/download/daily/archive/
And as well on these other pages: #12 (comment)

Has this issue been closed by mistake? I can still see the "All Archived Builds" link at the bottom of https://builder.blender.org/download/daily/archive/ And as well on these other pages: https://projects.blender.org/infrastructure/blender-buildbot-www/issues/12#issuecomment-1284785
Sergey Sharybin commented 2024-10-28 16:59:13 +01:00
Owner
Copy Link

@xan2622 The issue is closed when commit it done. It's how Gitea handles it. It doesn't necessarily mean the code is actually deployed to production.

@martonlente It would be good if the UI/web people will communicate to the people who actually run and use the system, so that they are aware that things change, and that a deployment might need to happen. Not sure if you was in the talks with @bartvdbraak about it.

Also please use code review in the future. The way the code is written is not how you're supposed to writing it. A lot of it is copying the existing bad practices, but without proper reviews we will not be able to move to a better state of code.

@xan2622 The issue is closed when commit it done. It's how Gitea handles it. It doesn't necessarily mean the code is actually deployed to production. @martonlente It would be good if the UI/web people will communicate to the people who actually run and use the system, so that they are aware that things change, and that a deployment might need to happen. Not sure if you was in the talks with @bartvdbraak about it. Also please use code review in the future. The way the code is written is not how you're supposed to writing it. A lot of it is copying the existing bad practices, but without proper reviews we will not be able to move to a better state of code.
👍 1 👀 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Márton Lente
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/blender-buildbot-www#12
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?