infrastructure/blender-devops
infrastructure/blender-devops
1
1
Fork 8
Code Pull Requests 3 Activity

Add --pre flag to pipenv installs for doc-api #14

Merged
Bart van der Braak merged 1 commits from Blendify/blender-devops:doc-apr-pip-pre into main 2024-11-29 11:09:30 +01:00
Conversation 2 Commits 1 Files Changed 1 +1 -1
Aaron Carlisle commented 2024-11-28 20:10:38 +01:00
Contributor
Copy Link

Similar to b4106f51f5

Similar to https://projects.blender.org/infrastructure/blender-devops/commit/b4106f51f552da1d1f9088498e44f0a9ee8f5101
Aaron Carlisle added 1 commit 2024-11-28 20:10:39 +01:00 
Similar to b4106f51f5
Sergey Sharybin requested review from Bart van der Braak 2024-11-29 11:01:17 +01:00
Sergey Sharybin commented 2024-11-29 11:03:09 +01:00
Owner
Copy Link

It would make it much easier to review the changes if they are explained a bit better: the fact that --pre is added can be seen from the code. What can't be seen in the why is it needed, what does it change or fix.

The commit message guidelines to Blender can be applied to more repositories.

It would make it much easier to review the changes if they are explained a bit better: the fact that `--pre` is added can be seen from the code. What can't be seen in the why is it needed, what does it change or fix. The commit message [guidelines](https://developer.blender.org/docs/handbook/guidelines/commit_messages/) to Blender can be applied to more repositories.
Bart van der Braak commented 2024-11-29 11:08:36 +01:00
Owner
Copy Link

I can add the following to the commit message:

Adding `--pre` flag to `pipenv install` allows us to use pre-release versions, which in this case is needed for building `doc-api` with `sphinx-basic-ng==1.0.0b2`
I can add the following to the commit message: ``` Adding `--pre` flag to `pipenv install` allows us to use pre-release versions, which in this case is needed for building `doc-api` with `sphinx-basic-ng==1.0.0b2` ```
Bart van der Braak merged commit 2252a39b4e into main 2024-11-29 11:09:30 +01:00
Bart van der Braak deleted branch doc-apr-pip-pre 2024-11-29 11:09:31 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Bart van der Braak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/blender-devops#14
No description provided.
Delete Branch "Blendify/blender-devops:doc-apr-pip-pre"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?