infrastructure/blender-devops
infrastructure/blender-devops
1
1
Fork 7
Code Pull Requests 5 Activity

Buildbot: Support running benchmarks for PRs #9

Open
Lukas Stockner wants to merge 1 commits from LukasStockner/blender-devops:support-patch-benchmark into main
pull from: LukasStockner/blender-devops:support-patch-benchmark
merge into: infrastructure:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 1 Commits 1 Files Changed 4 +113 -29
Lukas Stockner commented 2024-10-04 01:27:17 +02:00
First-time contributor
Copy Link

This works similarly to the daily benchmarks: It downloads the previous results, appends the new ones, generates the report from them and then pushes it to the server to overwrite the previous result.

The main difference is that now there's two inputs - the daily benchmark as a baseline, and the previous benchmark runs for that specific PR. The latter ones get updated, the former is left alone of course.

Instead of rendering the usual performance timeline, it uses blender/blender#128553 in order to render a relative performance difference report between the baseline and the PR version(s).

The delivery of the benchmark results has to happen before the packaging step, since that clears the entire output folder. I guess this also breaks delivery of test results already, but apparently that's not used or something?

This works similarly to the daily benchmarks: It downloads the previous results, appends the new ones, generates the report from them and then pushes it to the server to overwrite the previous result. The main difference is that now there's two inputs - the daily benchmark as a baseline, and the previous benchmark runs for that specific PR. The latter ones get updated, the former is left alone of course. Instead of rendering the usual performance timeline, it uses https://projects.blender.org/blender/blender/pulls/128553 in order to render a relative performance difference report between the baseline and the PR version(s). The delivery of the benchmark results has to happen before the packaging step, since that clears the entire output folder. I guess this also breaks delivery of test results already, but apparently that's not used or something?
Lukas Stockner added 1 commit 2024-10-04 01:27:18 +02:00
Lukas Stockner requested review from Sergey Sharybin 2024-10-04 01:27:42 +02:00
Sergey Sharybin requested review from Bart van der Braak 2024-10-14 19:00:01 +02:00
Sergey Sharybin commented 2024-10-14 19:00:47 +02:00
Owner
Copy Link

Thanks! It is definitely something we need to have. Will try to put it into agenda for self and Bart. Might be a bit tricky due to the time constraints.

Thanks! It is definitely something we need to have. Will try to put it into agenda for self and Bart. Might be a bit tricky due to the time constraints.
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u support-patch-benchmark:LukasStockner-support-patch-benchmark
git checkout LukasStockner-support-patch-benchmark
Sign in to join this conversation.
Reviewers
No reviewers
Sergey Sharybin
Bart van der Braak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/blender-devops#9
No description provided.
Delete Branch "LukasStockner/blender-devops:support-patch-benchmark"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?