infrastructure/blender-id
0
4
Fork 0
Code Issues 11 Pull Requests Projects Releases Wiki Activity

Send user-modified only to webhooks of relevant OAuth apps #93585

Closed
Anna Sirota wants to merge 5 commits from webhook-oauth-app-required into main
pull from: webhook-oauth-app-required
merge into: infrastructure:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 0 Commits 5 Files Changed 8 +249 -20
Anna Sirota commented 2024-06-17 10:22:27 +02:00
Owner
Copy Link

This changes the following:

  • OAuth app is now required when webhook is created or updated.
  • No user-modified will be sent to a webhook unless that user had logged in using that webhook's OAuth app at some point.

This breaks local setups of Blender ID: webhooks that don't have apps linked to them have to be updated or removed, otherwise migration added in this PR will break.

This changes the following: * OAuth app is now required when webhook is created or updated. * No `user-modified` will be sent to a webhook unless that user had logged in using that webhook's OAuth app at some point. This **breaks local setups** of Blender ID: webhooks that don't have apps linked to them have to be updated or removed, otherwise migration added in this PR will break.
Anna Sirota added 4 commits 2024-06-17 10:22:28 +02:00
Anna Sirota requested review from Oleg-Komarov 2024-06-17 10:22:36 +02:00
Anna Sirota added 1 commit 2024-06-17 10:29:39 +02:00
Oleg-Komarov approved these changes 2024-06-17 10:41:27 +02:00
Anna Sirota changed title from WIP: Send user-modified only to webhooks of relevant OAuth apps to Send user-modified only to webhooks of relevant OAuth apps 2024-06-17 10:41:39 +02:00
Anna Sirota closed this pull request 2024-06-17 10:50:22 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Oleg-Komarov
Labels
Clear labels   
legacy project
Infrastructure: blender.org

  
legacy project
Infrastructure: Websites

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status::Confirmed
  
Status
Duplicate

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Report

  
Type
To Do

No Label
legacy project
Infrastructure: blender.org
legacy project
Infrastructure: Websites
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status::Confirmed
Status
Duplicate
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/blender-id#93585
No description provided.
Delete Branch "webhook-oauth-app-required"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?