infrastructure/blender-id
0
4
Fork 0
Code Issues 11 Pull Requests Projects Releases Wiki Activity

UI: Blender-id web-assets v2 upgrade #93590

Merged
Márton Lente merged 28 commits from ui/web-assets-v2-upgrade into main 2024-08-22 14:41:33 +02:00
Conversation 2 Commits 28 Files Changed 13 +200 -133
Márton Lente commented 2024-08-21 15:15:30 +02:00
Owner
Copy Link

This pull request upgrades Git submodule Web Assets to v2, resolves post-upgrade issues, and makes the necessary project-specific changes.

Web Assets v2 brings UI fixes, improvements, and new development features to the platform as detailed on the Web Assets v2 guidelines and notes wiki page.

Visual changes are kept to a minimum and will be added later in a dedicate design pass.

Screenshots:

image
image
image
image
image

This pull request upgrades Git submodule Web Assets to v2, resolves post-upgrade issues, and makes the necessary project-specific changes. Web Assets v2 brings UI fixes, improvements, and new development features to the platform as detailed on the Web Assets [v2 guidelines and notes](https://projects.blender.org/infrastructure/web-assets/wiki/v2-guidelines-and-notes.md) wiki page. Visual changes are kept to a minimum and will be added later in a dedicate design pass. **Screenshots:** ![image](https://projects.blender.org/attachments/61569966-f316-48d2-af5e-3b01d21cb085) ![image](https://projects.blender.org/attachments/179fbcde-96d7-4502-b12c-68d6fbc653d7) ![image](https://projects.blender.org/attachments/0122b314-9665-428a-be3e-7280f7188421) ![image](https://projects.blender.org/attachments/60ec2429-eb57-4e83-a950-2b917b2402e1) ![image](https://projects.blender.org/attachments/db01abb6-d67a-424e-b1f9-7f88ba5fd065)
blender-id-ui-web-assets-v2-upgrade-min.png
501 KiB
blender-id-ui-web-assets-v2-upgrade-1-min-cropped.png
121 KiB
blender-id-ui-web-assets-v2-upgrade-4-min.png
477 KiB
blender-id-ui-web-assets-v2-upgrade-3-min-cropped.png
51 KiB
blender-id-ui-web-assets-v2-upgrade-2-min-cropped.png
49 KiB
Márton Lente added 24 commits 2024-08-21 15:15:32 +02:00 
Revise and explicit sizing and spacing values, and implement modular sizing
and spacing based on variable spacer.
Revise and explicit sizing and spacing values, and implement modular sizing
and spacing based on variable spacer to partial auth.
Implement style bg filter blur and noise to floating boxes, reusing styles
from blender-studio.
Márton Lente added 1 commit 2024-08-21 15:27:52 +02:00 
Prevent table data content from wrapping to multiple lines.
Márton Lente changed title from WIP: Blender-id web-assets v2 upgrade to UI: Blender-id web-assets v2 upgrade 2024-08-21 15:54:03 +02:00
Márton Lente requested review from Pablo Vazquez 2024-08-21 15:54:33 +02:00
Pablo Vazquez commented 2024-08-21 22:19:15 +02:00
Owner
Copy Link

Looks good! Just a few notes.

The screenshots are not full page (the bottom links are missing), and quite small, is that on purpose?

The box padding is quite small now. I think it looked fine before, for a page with so much space around it I think it needs it. Keep in mind to also bring back the bottom margin of the Blender logo (matches the box padding).

Before After
before after
Looks good! Just a few notes. The screenshots are not full page (the bottom links are missing), and quite small, is that on purpose? The box padding is quite small now. I think it looked fine before, for a page with so much space around it I think it needs it. Keep in mind to also bring back the bottom margin of the Blender logo (matches the box padding). |Before|After| |----|----| |![before](/attachments/5508db13-51c1-40b8-9747-341c37847725)|![after](https://projects.blender.org/attachments/61569966-f316-48d2-af5e-3b01d21cb085)|
image.png
1.6 MiB
👍 1
Márton Lente added 1 commit 2024-08-22 10:22:53 +02:00 
Part of #93590
Márton Lente added 1 commit 2024-08-22 10:32:49 +02:00 
Part of #93590
Márton Lente added 1 commit 2024-08-22 11:10:03 +02:00 
Part of #93590
Márton Lente commented 2024-08-22 11:27:25 +02:00
Author
Owner
Copy Link

@pablovazquez thank you for the review. I made the following changes:

  • I adjusted the bottom links' spacings, see on the screenshot. They were missing because of the lack of flatpages on the local install.
  • I increased the box's inner spacings. Now they're two times the unit of vertical spacings applied within the box.
  • I matched the logo's bottom margin with inner spacings. I cropped the logo image to size, so now it's a perfect match.

Screenshot:

blender-id-ui-web-assets-v2-upgrade-sm.png

I resized screenshots to fit 800px width within Gitea thread's, but I'll stop doing this since they can be opened on a new tab which might be useful.

@pablovazquez thank you for the review. I made the following changes: - I adjusted the bottom links' spacings, see on the screenshot. They were missing because of the lack of flatpages on the local install. - I increased the box's inner spacings. Now they're two times the unit of vertical spacings applied within the box. - I matched the logo's bottom margin with inner spacings. I cropped the logo image to size, so now it's a perfect match. **Screenshot:** ![blender-id-ui-web-assets-v2-upgrade-sm.png](/attachments/fb8deb2a-4064-4a68-8596-132160306ce7) I resized screenshots to fit 800px width within Gitea thread's, but I'll stop doing this since they can be opened on a new tab which might be useful.
blender-id-ui-web-assets-v2-upgrade-sm.png
1.5 MiB
❤️ 1
Pablo Vazquez approved these changes 2024-08-22 12:00:39 +02:00
Pablo Vazquez left a comment
Owner
Copy Link

Awesome, thanks!

I resized screenshots to fit 800px width within Gitea thread's, but I'll stop doing this since they can be opened on a new tab which might be useful.

Gitea is confusing because the preview shows the image overflowing the container, but in the actual thread it has max-width set so it's fine. I personally never scale down images because users can open them in a new window, which I do, especially handy for comparing and seeing 1:1.

Awesome, thanks! > I resized screenshots to fit 800px width within Gitea thread's, but I'll stop doing this since they can be opened on a new tab which might be useful. Gitea is confusing because the preview shows the image overflowing the container, but in the actual thread it has max-width set so it's fine. I personally never scale down images because users can open them in a new window, which I do, especially handy for comparing and seeing 1:1.
👍 1
Márton Lente merged commit de3d6fbaf1 into main 2024-08-22 14:41:33 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Pablo Vazquez
Labels
Clear labels   
legacy project
Infrastructure: blender.org

  
legacy project
Infrastructure: Websites

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status::Confirmed
  
Status
Duplicate

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Report

  
Type
To Do

No Label
legacy project
Infrastructure: blender.org
legacy project
Infrastructure: Websites
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status::Confirmed
Status
Duplicate
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/blender-id#93590
No description provided.
Delete Branch "ui/web-assets-v2-upgrade"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?