infrastructure/blender-org
5
4
Fork 1
Code Issues 16 Pull Requests Projects Releases Wiki Activity

UI: Implement JavaScript getOS function Windows platform architecture detection #104136

Merged
Márton Lente merged 15 commits from get-os-win-arm into main 2024-11-08 12:03:41 +01:00
Conversation 2 Commits 15 Files Changed 2 +164 -97
Márton Lente commented 2024-11-06 18:08:17 +01:00
Owner
Copy Link

This pull request implements x86 and Arm architectures detection for the Windows platform, following Microsoft's recommendations.

As the navigator.userAgentData.getHighEntropyValues built-in browser method is supported by Chromium browsers but not by Gecko browsers (e.g. Firefox), its effect is limited and doesn't resolve architecture detection in all browsers. In browsers that don't support it, Windows is detected and all available downloads are displayed for the platform.

The navigator.userAgentData.getHighEntropyValues is an asynchronous browser method by design and needs to be handled accordingly. The getOS function has been rewritten to handle its promise chain asynchronously. Additionally, the calling method of the getOS function has been updated to an async IIFE, awaiting its response.

The PR has been manually tested on a physical Windows Arm machine running Chromium-based browser. The OS variable returns windows-arm. ✅

As of Blender 4.2.3 LTS, Windows Arm display the blender.org Download page like this, after the PR:

image

This pull request implements x86 and Arm architectures detection for the Windows platform, following [Microsoft's recommendations](https://learn.microsoft.com/en-us/microsoft-edge/web-platform/how-to-detect-win11#sample-code-for-detecting-arm-or-x86). As the `navigator.userAgentData.getHighEntropyValues` built-in browser method is supported by Chromium browsers but not by Gecko browsers (e.g. Firefox), its effect is limited and doesn't resolve architecture detection in all browsers. In browsers that don't support it, Windows is detected and all available downloads are displayed for the platform. The `navigator.userAgentData.getHighEntropyValues` is an asynchronous browser method by design and needs to be handled accordingly. The `getOS` function has been rewritten to handle its promise chain asynchronously. Additionally, the calling method of the `getOS` function has been updated to an async IIFE, awaiting its response. The PR has been manually tested on a physical Windows Arm machine running Chromium-based browser. The `OS` variable returns `windows-arm`. ✅ As of Blender 4.2.3 LTS, Windows Arm display the blender.org Download page like this, after the PR: ![image](https://projects.blender.org/attachments/18560d0c-3b1e-4b08-ab3a-21db97f8f61e)
blender-org-get-os-arm.png
249 KiB
Márton Lente added 11 commits 2024-11-06 18:08:18 +01:00
Márton Lente added 1 commit 2024-11-07 11:02:11 +01:00
Márton Lente added 1 commit 2024-11-07 11:48:18 +01:00
Márton Lente requested review from Pablo Vazquez 2024-11-07 11:49:21 +01:00
Márton Lente changed title from WIP: Implement JavaScript getOS function Windows platform architecture detection to UI: Implement JavaScript getOS function Windows platform architecture detection 2024-11-07 15:14:59 +01:00
Márton Lente added 1 commit 2024-11-08 11:19:19 +01:00 
Part of #104136
Márton Lente added 1 commit 2024-11-08 11:20:53 +01:00 
Part of #104136
Márton Lente commented 2024-11-08 11:41:59 +01:00
Author
Owner
Copy Link

@pablovazquez the Download button's conditional display logic has also been added. This is how it should look like if the Windows Arm platform is present within platforms, on a Windows Arm machine:

blender-org-get-os-arm-1.png

It has been tested on a physical Windows Arm laptop in Chromium browsers using the private /download-arm test page.

Important:
The Arm download markup was manually added to the temporary page-download-arm.php template. Both the WP test page, and the temporary page-download-arm.php file should be removed after the PR has been merged. (The latter will happen automatically on the next 'live' deployment.) For now, I made the test page private – if you want to test, it should just work.

@pablovazquez the Download button's conditional display logic has also been added. This is how it should look like if the Windows Arm platform is present within platforms, on a Windows Arm machine: ![blender-org-get-os-arm-1.png](/attachments/f68349e1-85bf-42b9-93ba-cff99332fdd5) It has been tested on a physical Windows Arm laptop in Chromium browsers using the private `/download-arm` test page. **Important:** The Arm download markup was manually added to the temporary `page-download-arm.php` template. Both the WP test page, and the temporary `page-download-arm.php` file should be removed after the PR has been merged. (The latter will happen automatically on the next 'live' deployment.) For now, I made the test page private – if you want to test, it should just work.
blender-org-get-os-arm-1.png
242 KiB
Pablo Vazquez approved these changes 2024-11-08 11:50:19 +01:00
Pablo Vazquez left a comment
Owner
Copy Link

Alright! Let's get this in production. This is as good as it gets in terms of testing for now until 4.3 comes out, but I think it will just work™ . It's similar to when Apple Silicon was added some time ago. And we will have to go through it again once Linux Arm builds are available.

Thanks!

Alright! Let's get this in production. This is as good as it gets in terms of testing for now until 4.3 comes out, but I _think_ it will just work™ . It's similar to when Apple Silicon was added some time ago. And we will have to go through it again once Linux Arm builds are available. Thanks!
❤️ 1
Márton Lente merged commit edb740f42d into main 2024-11-08 12:03:41 +01:00
Márton Lente commented 2024-11-08 12:14:42 +01:00
Author
Owner
Copy Link

Thank you for your approval and feedback. The pull request was merged to main. The temporary test page was cleaned up and removed. The changes will get deployed soon.

Adding other architecture-based conditions later should be straightforward now that the navigator.userAgentData.getHighEntropyValues method's handling is present.

Thank you for your approval and feedback. The pull request was merged to `main`. The temporary test page was cleaned up and removed. The changes will get deployed soon. Adding other architecture-based conditions later should be straightforward now that the `navigator.userAgentData.getHighEntropyValues` method's handling is present.
Sign in to join this conversation.
Reviewers
No reviewers
Pablo Vazquez
Labels
Clear labels   
legacy module
Rendering & Cycles

  
legacy module
User Interface

  
legacy project
Cycles

  
legacy project
Documentation

  
legacy project
Infrastructure: blender.org

  
legacy project
Infrastructure: Blender Web Assets

  
legacy project
Infrastructure: Websites

  
legacy project
User Interface

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Report

  
Type
To Do

No Label
legacy module
Rendering & Cycles
legacy module
User Interface
legacy project
Cycles
legacy project
Documentation
legacy project
Infrastructure: blender.org
legacy project
Infrastructure: Blender Web Assets
legacy project
Infrastructure: Websites
legacy project
User Interface
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/blender-org#104136
No description provided.
Delete Branch "get-os-win-arm"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?