Color missing in CSS for inserted parts of a message diff #63
Labels
No Label
Service
Buildbot
Service
Chat
Service
Gitea
Service
Translate
Type
Bug
Type
Config
Type
Deployment
Type
Feature
Type
Setup
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: infrastructure/blender-projects-platform#63
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
When showing diffs in message editions, only the deleted parts get highlighted in red, the inserted parts do not get colored green. See for example the main message edition in blender/blender#109928.
It looks like the deleted parts use the
--color-syntax-GenericDeleted-text
and--color-syntax-GenericDeleted-bg
variables, while the inserted parts use--color-syntax-GenericInserted-text
and--color-syntax-GenericInserted-bg
, but these are not defined. Instead, there is a single--color-syntax-GenericInserted
, probably from an older naming scheme.This makes it confusing to know what actually changed between edits.
Can confirm.
Thank you! Indeed this was based on an older naming scheme from the library used to highlight.
Ideally I would use
hsla
(with transparency so it works in other themes and when overlapped) but these colors go through some compiler that doesn't support it yet.Accepted and merged. Should be part of the next deployment.
Is the problem still relevant?
No? As mentioned in my last comment, closing this issue because the patch has been accepted and merged to main.
I mean, right now I don't see the diff at all in the edit history
![image](/infrastructure/blender-projects-platform/attachments/2b330977-2967-4174-8479-a9a548bb5cf5)
From my comment: