infrastructure/blender-projects-platform
6
1
Issues 34 Projects 1 Activity

Color missing in CSS for inserted parts of a message diff #63

New Issue
Closed
opened 2023-07-12 19:42:08 +02:00 by Damien Picard · 6 comments
Damien Picard commented 2023-07-12 19:42:08 +02:00
Copy Link

When showing diffs in message editions, only the deleted parts get highlighted in red, the inserted parts do not get colored green. See for example the main message edition in blender/blender#109928.

Current Expected
image image

It looks like the deleted parts use the --color-syntax-GenericDeleted-text and --color-syntax-GenericDeleted-bg variables, while the inserted parts use --color-syntax-GenericInserted-text and --color-syntax-GenericInserted-bg, but these are not defined. Instead, there is a single --color-syntax-GenericInserted, probably from an older naming scheme.

This makes it confusing to know what actually changed between edits.

When showing diffs in message editions, only the deleted parts get highlighted in red, the inserted parts do not get colored green. See for example the main message edition in blender/blender#109928. | Current | Expected | |-------------------------------------------------------------|-------------------------------------------------------------| | ![image](/attachments/746f1068-5f10-4fd4-a666-0bf6c61b5794) | ![image](/attachments/fa9ed10d-f5d7-4a83-927e-50b4dd2c23b5) | It looks like the deleted parts use the `--color-syntax-GenericDeleted-text` and `--color-syntax-GenericDeleted-bg` variables, while the inserted parts use `--color-syntax-GenericInserted-text` and `--color-syntax-GenericInserted-bg`, but these are not defined. Instead, there is a single `--color-syntax-GenericInserted`, probably from an older naming scheme. This makes it confusing to know what actually changed between edits.
image.png
19 KiB
image.png
18 KiB
Iliya Katushenock commented 2023-07-12 20:10:08 +02:00
Copy Link

Can confirm.

Can confirm.
Pablo Vazquez commented 2023-07-21 12:00:52 +02:00
Owner
Copy Link

Thank you! Indeed this was based on an older naming scheme from the library used to highlight.

Ideally I would use hsla (with transparency so it works in other themes and when overlapped) but these colors go through some compiler that doesn't support it yet.

Accepted and merged. Should be part of the next deployment.

Thank you! Indeed this was based on an older naming scheme from the library used to highlight. Ideally I would use `hsla` (with transparency so it works in other themes and when overlapped) but these colors go through some compiler that doesn't support it yet. Accepted and merged. Should be part of the next deployment.
🎉 1
Iliya Katushenock commented 2023-07-22 15:40:47 +02:00
Copy Link

Is the problem still relevant?

Is the problem still relevant?
Pablo Vazquez commented 2023-07-22 18:49:48 +02:00
Owner
Copy Link

Is the problem still relevant?

No? As mentioned in my last comment, closing this issue because the patch has been accepted and merged to main.

> Is the problem still relevant? No? As mentioned in my last comment, closing this issue because the patch has been accepted and merged to main.
Iliya Katushenock commented 2023-07-22 18:52:43 +02:00
Copy Link

I mean, right now I don't see the diff at all in the edit history
image

I mean, right now I don't see the diff at all in the edit history ![image](/attachments/2b330977-2967-4174-8479-a9a548bb5cf5)
image.png
47 KiB
Pablo Vazquez commented 2023-07-22 18:55:13 +02:00
Owner
Copy Link

I mean, right now I don't see the diff at all in the edit history

From my comment:

Accepted and merged. Should be part of the next deployment.

> I mean, right now I don't see the diff at all in the edit history From my comment: > Accepted and merged. Should be part of the next deployment.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
blender customization

   
bug

Something is not working

  
buildbot

   
deployment

   
gitea feature request

   
help wanted

Need some help

  
policy
No Label
blender customization
bug
buildbot
deployment
gitea feature request
help wanted
policy
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/blender-projects-platform#63
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?