Color missing in CSS for inserted parts of a message diff #63
When showing diffs in message editions, only the deleted parts get highlighted in red, the inserted parts do not get colored green. See for example the main message edition in blender/blender#109928.
It looks like the deleted parts use the
--color-syntax-GenericDeleted-bg variables, while the inserted parts use
--color-syntax-GenericInserted-bg, but these are not defined. Instead, there is a single
--color-syntax-GenericInserted, probably from an older naming scheme.
This makes it confusing to know what actually changed between edits.
Thank you! Indeed this was based on an older naming scheme from the library used to highlight.
Ideally I would use
hsla (with transparency so it works in other themes and when overlapped) but these colors go through some compiler that doesn't support it yet.
Accepted and merged. Should be part of the next deployment.
Is the problem still relevant?
No? As mentioned in my last comment, closing this issue because the patch has been accepted and merged to main.
No due date set.
No dependencies set.
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?