Color missing in CSS for inserted parts of a message diff #63

New Issue

Damien Picard · 2023-07-12T19:42:08+02:00

Damien Picard commented

2023-07-12 19:42:08 +02:00

When showing diffs in message editions, only the deleted parts get highlighted in red, the inserted parts do not get colored green. See for example the main message edition in blender/blender#109928.

Current	Expected

It looks like the deleted parts use the --color-syntax-GenericDeleted-text and --color-syntax-GenericDeleted-bg variables, while the inserted parts use --color-syntax-GenericInserted-text and --color-syntax-GenericInserted-bg, but these are not defined. Instead, there is a single --color-syntax-GenericInserted, probably from an older naming scheme.

This makes it confusing to know what actually changed between edits.

When showing diffs in message editions, only the deleted parts get highlighted in red, the inserted parts do not get colored green. See for example the main message edition in blender/blender#109928. | Current | Expected | |-------------------------------------------------------------|-------------------------------------------------------------| | ![image](/attachments/746f1068-5f10-4fd4-a666-0bf6c61b5794) | ![image](/attachments/fa9ed10d-f5d7-4a83-927e-50b4dd2c23b5) | It looks like the deleted parts use the `--color-syntax-GenericDeleted-text` and `--color-syntax-GenericDeleted-bg` variables, while the inserted parts use `--color-syntax-GenericInserted-text` and `--color-syntax-GenericInserted-bg`, but these are not defined. Instead, there is a single `--color-syntax-GenericInserted`, probably from an older naming scheme. This makes it confusing to know what actually changed between edits.

image.png

19 KiB

image.png

18 KiB

Iliya Katushenock commented

2023-07-12 20:10:08 +02:00

Can confirm.

Damien Picard referenced this issue from a commit

2023-07-20 23:25:16 +02:00

Fix color missing in CSS for inserted parts of a message diff

Damien Picard closed this issue

2023-07-20 23:25:16 +02:00

Damien Picard referenced a pull request from infrastructure/gitea-custom that will close this issue

2023-07-20 23:25:49 +02:00

Fix color missing in CSS for inserted parts of a message diff #4

Damien Picard reopened this issue

2023-07-20 23:26:21 +02:00

Pablo Vazquez closed this issue

2023-07-21 11:58:24 +02:00

Pablo Vazquez commented

2023-07-21 12:00:52 +02:00

Thank you! Indeed this was based on an older naming scheme from the library used to highlight.

Ideally I would use hsla (with transparency so it works in other themes and when overlapped) but these colors go through some compiler that doesn't support it yet.

Accepted and merged. Should be part of the next deployment.

Thank you! Indeed this was based on an older naming scheme from the library used to highlight. Ideally I would use `hsla` (with transparency so it works in other themes and when overlapped) but these colors go through some compiler that doesn't support it yet. Accepted and merged. Should be part of the next deployment.

🎉 1

Iliya Katushenock commented

2023-07-22 15:40:47 +02:00

Is the problem still relevant?