infrastructure/conference-website
1
1
Fork 1
Code Issues 14 Pull Requests Releases Activity

UI: 2024 Hero component options #103971

Merged
Márton Lente merged 66 commits from ui/2024-hero-options into main 2024-09-24 13:00:31 +02:00
Conversation 3 Commits 66 Files Changed 2 +34 -4
Márton Lente commented 2024-09-19 13:07:07 +02:00
Owner
Copy Link

Important:

  • This pull request is dependent on the following PR, that must be merged first: #103970

This pull request adds UI changes to the base template, to improve conference hero creatives display for BCON 2024 edition.

Based on work-in-progress back-end changes it adds dynamic, reusable options for the hero component's display (preferred), or registers a new flatpage template for the 2024 edition in particular (alternative). The PR needs back-end help along template comments starting with the TODO: @back-end prefix.

Screenshot:

ui-conference-website-2024-hero-options.png

**Important:** - [x] This pull request is dependent on the following PR, that must be merged first: https://projects.blender.org/infrastructure/conference-website/pulls/103970 This pull request adds UI changes to the base template, to improve conference hero creatives display for BCON 2024 edition. Based on work-in-progress back-end changes it adds dynamic, reusable options for the _hero_ component's display (preferred), or registers a new _flatpage_ template for the 2024 edition in particular (alternative). The PR needs back-end help along template comments starting with the _TODO: @back-end_ prefix. **Screenshot:** ![ui-conference-website-2024-hero-options.png](https://projects.blender.org/attachments/f25ff196-fcee-4d26-9393-9fcec85d46d1)
ui-conference-website-2024-hero-options.png
9.5 MiB
Márton Lente added 39 commits 2024-09-19 13:07:09 +02:00 
Run post web-assets v2 upgrade script bash helper and make project-specific
replacements adjustments base.
Fix background colours after web-assets v2 upgrade, with variable and markup
changes.
Basic conversion of explicit sizing values to web-assets v2 modular sizing, or
rem-based sizing from pixels equivalents.
Change template presentations cards components to box to improve layout
consistency and simplify markup after web-assets v2 upgrade.
Fix remove table rendering when no entries are present in object_list.
Fix remove table rendering when no tickets are present in object_list.
Apply web-assets v2 form-control styles to immutabe, immutable rendered
classes coming from the back-end.
Add new visual options' base styles for hero component, to prepare styling
choices for individual conference pages.
This reverts commit 504be9cdb9.
Make logo vertically offset upwards in hero-lg containers for a more
balanced display.
Márton Lente commented 2024-09-19 13:12:19 +02:00
Author
Owner
Copy Link

@fsiddi @pablovazquez see the basic proposal above, we can go ahead according to the description's options.

@fsiddi @pablovazquez see the basic proposal above, we can go ahead according to the description's options.
Márton Lente added 1 commit 2024-09-19 16:11:04 +02:00 
Part of #103970
Márton Lente added 1 commit 2024-09-19 17:01:51 +02:00 
See Release notes for details.
Part of #103970
Márton Lente added 1 commit 2024-09-19 17:03:09 +02:00 
Make navbar btn cta more prominent.
Part of #103970
Márton Lente added 15 commits 2024-09-20 11:48:24 +02:00 
Part of #103970
Part of #103970
See Release notes for details.
Part of #103970
Make navbar btn cta more prominent.
Part of #103970
Part of #103970
Part of #103970
Make profile bio text font-size smaller.
Part of #103970
Part of #103970
Part of #103970
Part of #103970
Part of #103970
Part of #103970
See Release notes for details.
Part of #103970
This reverts commit 54469a8e84.
Márton Lente changed target branch from main to ui/web-assets-v2-update 2024-09-23 11:34:56 +02:00
Márton Lente changed target branch from ui/web-assets-v2-update to main 2024-09-23 16:58:53 +02:00
Márton Lente changed target branch from main to ui/web-assets-v2-update 2024-09-23 16:59:12 +02:00
Márton Lente added 1 commit 2024-09-23 17:14:55 +02:00
Márton Lente added 13 commits 2024-09-23 17:25:16 +02:00 
Upgrades Git submodule Web Assets to v2, resolves post-upgrade issues,
and makes the necessary project-specific changes. See the pull request
for details.

Pull Request: #103970
Add style hero-bg size web-assets override to match web-assets pre-v2 styling.
This reverts commit d2470c59c0.
Make hero content img max-width expliciti to work better edition logos with
with various aspect ratios.
Make schedule btn-toggles be displayed as buttons.
Unifying all schedule notices into one.
Fix schedule day toggles components not displaying on medium screens, by
shifting breakpoints.
It's more correct and easy to guess by filename, since we are not only
styling events but also location channels in the horizontal schedule.
* Use sidebar.
* Unify layout, use title for each section.
* Clearer copy.
Remove specific inline bg position style from base template to make bg images
alignment match their positioning when they were set.
* Add table header
* Style "claimed" label
* Don't display "Order Number: " for each element.
Fix hero-bg class namings after web-assets v2 upgrade for specific style
overrides.
Márton Lente changed target branch from ui/web-assets-v2-update to main 2024-09-23 17:25:59 +02:00
Márton Lente added 1 commit 2024-09-23 17:38:40 +02:00
Márton Lente added 1 commit 2024-09-23 17:47:22 +02:00
Márton Lente added 1 commit 2024-09-23 17:48:07 +02:00
Márton Lente commented 2024-09-23 17:56:51 +02:00
Author
Owner
Copy Link

@fsiddi @pablovazquez the PR is up to date again, with main as its target branch. To continue, I'd need some back-end help, and to decide how we wrap this up. See the options below:

  1. Advanced: We register hero display options in the admin. I'd need help with todos prefixed with TODO: @back-end in code.
  2. Basic: We simply register a new flatpage template for the 2024 edition. In this option, I'd only need help with the todo prefixed with TODO: back-end !important task to decouple the navbar logo from the logo that is displayed in the hero. The rest I could manage.

Thank you in advance!

@fsiddi @pablovazquez the PR is up to date again, with `main` as its target branch. To continue, I'd need some back-end help, and to decide how we wrap this up. See the options below: 1. **Advanced:** We register hero display options in the admin. I'd need help with todos prefixed with _TODO: @back-end_ in code. 2. **Basic:** We simply register a new flatpage template for the 2024 edition. In this option, I'd only need help with the todo prefixed with _TODO: back-end !important_ task to decouple the navbar logo from the logo that is displayed in the hero. The rest I could manage. Thank you in advance!
Márton Lente added 1 commit 2024-09-24 11:30:58 +02:00
Pablo Vazquez approved these changes 2024-09-24 12:48:02 +02:00
Pablo Vazquez left a comment
Owner
Copy Link

We can get this in as is and I can do the TODO's before we deploy.

I'd simply make a new hero component pug file and pass on variables to enable different features like gradient and size.

We can get this in as is and I can do the TODO's before we deploy. I'd simply make a new hero component pug file and pass on variables to enable different features like gradient and size.
👍 1
Márton Lente changed title from WIP: 2024 Hero component options to UI: 2024 Hero component options 2024-09-24 12:56:48 +02:00
Márton Lente merged commit bb22c1d21f into main 2024-09-24 13:00:31 +02:00
Márton Lente commented 2024-09-24 13:04:57 +02:00
Author
Owner
Copy Link

@pablovazquez thank you for the review and confirmation. I merged this.

I'll check how the new component file with variable passing is set up, so that next time I can submit the pull request in a more complete state.

@pablovazquez thank you for the review and confirmation. I merged this. I'll check how the new component file with variable passing is set up, so that next time I can submit the pull request in a more complete state.
❤️ 1
Sign in to join this conversation.
Reviewers
No reviewers
Pablo Vazquez
Labels
Clear labels   
legacy project
Infrastructure: Websites

  
Priority
High

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Report

  
Type
To Do

No Label
legacy project
Infrastructure: Websites
Priority
High
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Resolved
Type
Bug
Type
Design
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/conference-website#103971
No description provided.
Delete Branch "ui/2024-hero-options"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?