infrastructure/developer-website
1
1
Fork 3
Code Pull Requests Activity

UI: Developer-website web-assets v2 upgrade #1

Merged
Márton Lente merged 9 commits from ui/web-assets-v2-upgrade into main 2024-08-27 11:36:32 +02:00
Conversation 0 Commits 9 Files Changed 9 +24568 -81
Márton Lente commented 2024-08-26 18:31:55 +02:00
Owner
Copy Link

This pull request upgrades Web Assets to v2 by adding pre-compiled BWA styles (as of v2.0.0-alpha.32), resolves post-upgrade issues, and makes the necessary project-specific changes.

Web Assets v2 brings UI fixes, improvements, and new development features to the platform as detailed on the Web Assets v2 guidelines and notes wiki page.

Visual changes are kept to a minimum. Some project-level cleanup has been done when converting components to use Web Assets v2 markup and styles.

Screenshot:

ui-developer-website-web-assets-v2-upgrade.png

Some project-level style overrides were added mainly to implement Web Assets modular vertical sizing, introduced in v2.

This pull request upgrades Web Assets to v2 by adding pre-compiled BWA styles (as of [v2.0.0-alpha.32](https://projects.blender.org/infrastructure/web-assets/releases/tag/v2.0.0-alpha.32)), resolves post-upgrade issues, and makes the necessary project-specific changes. Web Assets v2 brings UI fixes, improvements, and new development features to the platform as detailed on the Web Assets [v2 guidelines and notes](https://projects.blender.org/infrastructure/web-assets/wiki/v2-guidelines-and-notes.md) wiki page. Visual changes are kept to a minimum. Some project-level cleanup has been done when converting components to use Web Assets v2 markup and styles. **Screenshot:** ![ui-developer-website-web-assets-v2-upgrade.png](/attachments/e8542627-78cb-4b61-b875-d95acfd1d8fb) Some project-level style overrides were added mainly to implement Web Assets modular vertical sizing, introduced in v2.
ui-developer-website-web-assets-v2-upgrade.png
6.4 MiB
Márton Lente added 6 commits 2024-08-26 18:31:56 +02:00 
Remove hotlinking stylesheet, and add compiled styles from code.blender.org,
pre-compiled with web-assets v2.0.0-alpha.32. Initialize web-assets v2 upgrade.
Upgrade classnames and styles to web-assets v2 base.
Cleanup and remove project styles that became redundant after
web-assets v2 upgrade.
Change navbar-global component to use the latest component markup from
web-assets v2.
Márton Lente changed title from WIP: Developer-website web-assets v2 upgrade to UI: Developer-website web-assets v2 upgrade 2024-08-26 18:34:22 +02:00
Márton Lente requested review from Pablo Vazquez 2024-08-26 18:34:33 +02:00
Pablo Vazquez requested changes 2024-08-26 18:40:46 +02:00
Dismissed
index.html Outdated
@ -19,3 +19,3 @@
<meta name="twitter:title" content="Blender Developer - developer.blender.org" />
<meta name="twitter:image" content="https://www.blender.org/wp-content/themes/bthree/assets_shared/images/blender_the_freedom_to_create_02.jpg" />
<link rel="stylesheet" href="https://code.blender.org/wp-content/themes/bthree-code/style.css?16052023" type="text/css" media="screen" />
<link rel="stylesheet" href="assets/css/style.css" type="text/css" media="screen" />
Pablo Vazquez commented 2024-08-26 18:40:12 +02:00
Owner
Copy Link

Missing the version argument so it gets cached by the browser.

Missing the version argument so it gets cached by the browser.
martonlente marked this conversation as resolved
index.html Outdated
@ -67,3 +57,3 @@
<div class="nav-global-container">
<nav>
<a href="https://developer.blender.org/" class="nav-global-logo is-active">
<a href="https://developer.blender.org/" class="nav-global-logo">
Pablo Vazquez commented 2024-08-26 18:40:43 +02:00
Owner
Copy Link

Why removing the is-active? This is the landing page of developer.blender.org, that's why it was set to be the "active" link.

Why removing the is-active? This is the landing page of developer.blender.org, that's why it was set to be the "active" link.
Márton Lente commented 2024-08-27 10:51:03 +02:00
Author
Owner
Copy Link

I wasn't sure if highlighting the logo was intentional, as it isn't currently highlighted on all projects' landing pages (missing e.g. in Web Assets). I fixed it and will make sure that the logo highlighting prevails on other projects as well, that we use to indicate we're on the home page of a project.

I wasn't sure if highlighting the logo was intentional, as it isn't currently highlighted on all projects' landing pages (missing e.g. in Web Assets). I fixed it and will make sure that the logo highlighting prevails on other projects as well, that we use to indicate we're on the home page of a project.
👍 1
Márton Lente added 1 commit 2024-08-27 10:44:57 +02:00 
Part of #1
Márton Lente added 1 commit 2024-08-27 10:47:16 +02:00 
Part of #1
Márton Lente requested review from Pablo Vazquez 2024-08-27 10:51:11 +02:00
Pablo Vazquez approved these changes 2024-08-27 11:07:38 +02:00
Pablo Vazquez left a comment
Owner
Copy Link

Thanks!

Thanks!
Márton Lente added 1 commit 2024-08-27 11:35:05 +02:00 
Part of #1
Márton Lente merged commit 686b661ec1 into main 2024-08-27 11:36:32 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Pablo Vazquez
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/developer-website#1
No description provided.
Delete Branch "ui/web-assets-v2-upgrade"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?