Braintree gateway ServerError not handled properly #81121

New Issue

Sybren A. Stüvel · 2020-09-24T10:52:05+02:00

Sybren A. Stüvel commented

2020-09-24 10:52:05 +02:00

When Braintree goes down, for example for maintenance, their SDK will raise a ServerError from /var/www/blender-fund/.venv/lib/python3.6/site-packages/braintree/util/http.py in raise_exception_from_status, line 49. This function is called indirectly by the call self.braintree.client_token.generate(params) from looper/gateways.py, function generate_client_token.

The exception is not caught properly, resulting in an internal server error. Probably it's best to catch this exception at a higher level than that particular call, and present a generic error message to the user.

When Braintree goes down, for example for maintenance, their SDK will raise a `ServerError` from `/var/www/blender-fund/.venv/lib/python3.6/site-packages/braintree/util/http.py` in `raise_exception_from_status`, line 49. This function is called indirectly by the call `self.braintree.client_token.generate(params)` from `looper/gateways.py`, function `generate_client_token`. The exception is not caught properly, resulting in an internal server error. Probably it's best to catch this exception at a higher level than that particular call, and present a generic error message to the user.

Sybren A. Stüvel commented

2020-09-24 10:52:05 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'