infrastructure/devfund-website
0
2
Fork 0
Code Issues 26 Pull Requests Projects 1 Releases Wiki Activity

Admin: Implement option to set nofollow per membership credit #96844

New Issue
Closed
opened 2024-05-02 18:54:50 +02:00 by Pablo Vazquez · 3 comments
Pablo Vazquez commented 2024-05-02 18:54:50 +02:00
Owner
Copy Link

At the moment, all membership credits that can contain links have the rel="nofollow" tag set in the template (membership_credit.html)

In some cases, admins may want to remove this tag.

I don't think we need this to be generic for other tags.
Something like {% if membership.nofollow %}rel="nofollow"{% endif %}.

It should be enabled by default for new memberships.

At the moment, all membership credits that can contain links have the `rel="nofollow"` tag set in the template (`membership_credit.html`) In some cases, admins may want to remove this tag. I don't think we need this to be generic for other tags. Something like `{% if membership.nofollow %}rel="nofollow"{% endif %}`. It should be enabled by default for new memberships.
Pablo Vazquez added the
Type
To Do
 label 2024-05-02 18:54:50 +02:00
Pablo Vazquez added the
Priority
Normal
 label 2024-05-03 12:38:31 +02:00
Pablo Vazquez changed title from Implement option to set nofollow tag per membership credit to Admin: Implement option to set nofollow per membership credit 2024-05-03 16:01:08 +02:00
Oleg-Komarov self-assigned this 2024-05-03 18:08:19 +02:00
Oleg-Komarov commented 2024-05-03 18:13:12 +02:00
Owner
Copy Link

I suggest inverting the default: add a field named suppress_nofollow that is False by default.
This is more in line with fail safe defaults - if we make a mistake somewhere (e.g. the field is not initialized), we fallback to a safer behavior.

I suggest inverting the default: add a field named `suppress_nofollow` that is False by default. This is more in line with fail safe defaults - if we make a mistake somewhere (e.g. the field is not initialized), we fallback to a safer behavior.
👍 1
Oleg-Komarov commented 2024-05-03 18:16:37 +02:00
Owner
Copy Link

image

![image](/attachments/505df282-b128-4bb8-895b-f79b62df7812)
image.png
20 KiB
Oleg-Komarov commented 2024-05-03 18:17:48 +02:00
Owner
Copy Link

Deployed in production.

Deployed in production.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
legacy project
Infrastructure: blender.org

  
legacy project
Infrastructure: Websites

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Needs Information from Developers

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Report

  
Type
To Do

No Label
legacy project
Infrastructure: blender.org
legacy project
Infrastructure: Websites
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Needs Information from Developers
Status
Resolved
Type
Bug
Type
Design
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Oleg-Komarov
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/devfund-website#96844
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?