infrastructure/extensions-website
4
8
Fork 10
Code Issues 20 Pull Requests 2 Projects Releases Wiki Activity

UI: Improve multi OS display #205

Merged
Oleg-Komarov merged 40 commits from ui/multi-os into main 2024-07-16 07:24:07 +02:00
Conversation 1 Commits 40 Files Changed 10 +257 -57
Márton Lente commented 2024-07-12 17:55:24 +02:00
Owner
Copy Link

This PR improves UI display of extensions with multiple platform variants.

The following items are work in progress, and will be added later:

  • Showing the item that is relevant to the current platform in the Other versions dropdown, while fading out the non-active items
  • Detect macOS architecture if possible, and only show the relevant item on the platform
  • Merging the display of platforms with different architectures in extensions details' Supported Platforms list
This PR improves UI display of extensions with multiple platform variants. The following items are work in progress, and will be added later: - [x] Showing the item that is relevant to the current platform in the _Other versions_ dropdown, while fading out the non-active items - [ ] Detect macOS architecture if possible, and only show the relevant item on the platform - [x] Merging the display of platforms with different architectures in extensions details' _Supported Platforms_ list
Márton Lente added 30 commits 2024-07-12 17:55:25 +02:00 
Show multi OS install buttons dynamically,
based on present active platform.
Add multi OS all versions dropdown to enable donwnload of other versions
for non-active platforms.
Improve template multi OS install buttons display based on coversation IRL.
File size display is work in progress.
Show the extension's size for the active platform in
the install button's details.
This reverts commit 2c550392cc.
Show the extension's size for the active platform in
the install button's details.
Refactor of #2c55039
Fix extension-detail dropdowns being overflown by subsequent panels.
Fix data-platform attribute for js function copyInstall URL
after database and back-end changes.
Fix btn-install-action-items separator styles when multiple OS-specific
install buttons are present.
Don't display size in extensions' details for extensions that have
multiple platform variant.
Oleg-Komarov added 1 commit 2024-07-13 20:44:35 +02:00
Márton Lente added 1 commit 2024-07-15 11:19:25 +02:00 
Show active platform in multi OS Other versions list with a dot indicator.
Part of #205
Oleg-Komarov commented 2024-07-15 11:55:11 +02:00
Owner
Copy Link

@dfelinto about grouping architectures per OS in the "supported platforms" list
image

once we get extensions for windows-arm64, it would make sense to do grouping for windows, not only for macOS

to implement this with the current data model, it will be easier if we had a more specific platform.name for windows-x64, then we could rely on the methods name_first_word and name_rest for grouping.
the problem is that currently name_rest for windows-x64 is empty, so it would look weird if we join an empty string and the "Arm" part of windows-arm64

to solve this we could just update the name field for windows-x64 to something other than "Windows", e.g. "Windows x64", what do you think?

@dfelinto about grouping architectures per OS in the "supported platforms" list ![image](/attachments/cf5cd38c-c10b-4b94-bc4f-d7b3d68921d9) once we get extensions for windows-arm64, it would make sense to do grouping for windows, not only for macOS to implement this with the current data model, it will be easier if we had a more specific platform.name for windows-x64, then we could rely on the methods `name_first_word` and `name_rest` for grouping. the problem is that currently `name_rest` for windows-x64 is empty, so it would look weird if we join an empty string and the "Arm" part of windows-arm64 to solve this we could just update the name field for windows-x64 to something other than "Windows", e.g. "Windows x64", what do you think?
image.png
13 KiB
Márton Lente added 1 commit 2024-07-15 12:05:08 +02:00 
This commit is part of a work in progress and is needed for testing.
Part of #205
Oleg-Komarov added 1 commit 2024-07-15 14:19:40 +02:00
Oleg-Komarov added 1 commit 2024-07-15 14:20:32 +02:00
Márton Lente added 1 commit 2024-07-15 15:17:22 +02:00 
Part of #205
Márton Lente added 1 commit 2024-07-15 16:21:53 +02:00 
Part of #205
Márton Lente added 1 commit 2024-07-15 17:12:48 +02:00 
Part of #205
Márton Lente added 1 commit 2024-07-15 17:22:37 +02:00 
Style dropdown multi OS download buttons based on active platform.
Part of #205
Márton Lente added 1 commit 2024-07-15 17:29:06 +02:00 
Part of #205
Oleg-Komarov merged commit 5ace0a8251 into main 2024-07-16 07:24:07 +02:00
Oleg-Komarov deleted branch ui/multi-os 2024-07-16 07:24:08 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Normal
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Type
Breaking
Breaking change that won't be backward compatible

  
Type
Documentation
Documentation changes

  
Type
Enhancement
Improve existing functionality

  
Type
Feature
New functionality

  
Type
Report
Something is not working

  
Type
Security
This is security issue

  
Type
Suggestion
New ideas and proposals

  
Type
Testing
Issue or pull request related to testing

No Label
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Type
Breaking
Type
Documentation
Type
Enhancement
Type
Feature
Type
Report
Type
Security
Type
Suggestion
Type
Testing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/extensions-website#205
No description provided.
Delete Branch "ui/multi-os"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?