Inconsistent Status of Add-on in Approval Queue #251

New Issue

Patiga · 2024-09-17T01:13:36+02:00

Patiga commented

2024-09-17 01:13:36 +02:00

In the approval queue page, my Add-on "Teeworlds and DDNet Map import" is listed with the status "Awaiting Changes".
When I click on the Add-on link, it lists the status "Awaiting Review"

I expect the status to be consistent across those pages.
Having clicked on a few other Add-ons, the status on the Add-on's page is always "Awaiting Review", which is probably a bug.

Is there a way for me to change the status from "Awaiting Changes", or can only reviewers change the status? I uploaded a new version which addresses the issue noticed.

In the [approval queue page](https://extensions.blender.org/approval-queue/twformats/), my Add-on "Teeworlds and DDNet Map import" is listed with the status "Awaiting Changes". When I [click on the Add-on link](https://extensions.blender.org/approval-queue/twformats/), it lists the status "Awaiting Review" I expect the status to be consistent across those pages. Having clicked on a few other Add-ons, the status on the Add-on's page is always "Awaiting Review", which is probably a bug. Is there a way for me to change the status from "Awaiting Changes", or can only reviewers change the status? I uploaded a new version which addresses the issue noticed.

Patiga added the

labels 2024-09-17 01:13:36 +02:00

Oleg-Komarov commented

2024-09-17 11:27:04 +02:00

Is there a way for me to change the status from "Awaiting Changes", or can only reviewers change the status?

In the comment form on the approval queue page you should see a dropdown for changing the status, it has a default "Comment" option selected, but you can select "Awaiting Review" before submitting the form.

I agree that we should make the status in the header of an individual extension approval page (we lack a good name for that page) consistent with what is displayed in the approval queue. Currently it displays an actual extension status, but it could display a last approval activity status instead. See the explanation below.

There are other places where the status display is diverging: extension cards in "My Extensions" page, sidebar block of the "Edit" page, and "Version History" (expand details for screenshots)

extension cards in "My Extensions" page

sidebar block of the "Edit" page

and "Version History"

Making those consistent as well may create more entanglement and needs more thought, due to how those statuses work.

The status values shown on the extension edit page and in approval queue are separate, and it indeed may appear confusing.
The reason to have them separate is that

extension can transition between these states draft <-> awaiting review -> approved, but once it is approved it remains approved (can only be blocklisted by admins afterwards)
approval queue status only shows the status of the last activity.

A moderator can leave an awaiting changes comment on a previously approved extension, but the extension itself remains in the approved status and doesn't become unlisted.

In the current implementation, the awaiting review status on the extension page is not granular enough to reflect an up-to-date state of the review process and only means that the extension is still under review (i.e. not in draft and not approved).

> Is there a way for me to change the status from "Awaiting Changes", or can only reviewers change the status? In the comment form on the approval queue page you should see a dropdown for changing the status, it has a default "Comment" option selected, but you can select "Awaiting Review" before submitting the form. --- I agree that we should make the status in the header of an individual extension approval page (we lack a good name for that page) consistent with what is displayed in the approval queue. Currently it displays an actual extension status, but it could display a last approval activity status instead. See the explanation below. <details> <summary> There are other places where the status display is diverging: extension cards in "My Extensions" page, sidebar block of the "Edit" page, and "Version History" (expand details for screenshots) </summary> extension cards in "My Extensions" page ![image](/attachments/400d65fe-af97-4278-be01-b321b11de3d0) sidebar block of the "Edit" page ![image](/attachments/624ba8e8-2c83-4f86-b8c0-da2792bd5a38) and "Version History" ![image](/attachments/1b7ec9b2-72a1-4706-8ab3-f6e9d71323bc) </details> Making those consistent as well may create more entanglement and needs more thought, due to how those statuses work. --- The status values shown on the extension edit page and in approval queue are separate, and it indeed may appear confusing. The reason to have them separate is that - extension can transition between these states `draft <-> awaiting review -> approved`, but once it is approved it remains approved (can only be blocklisted by admins afterwards) - approval queue status only shows the status of the last activity. A moderator can leave an `awaiting changes` comment on a previously approved extension, but the extension itself remains in the `approved` status and doesn't become unlisted. In the current implementation, the `awaiting review` status on the extension page is not granular enough to reflect an up-to-date state of the review process and only means that the extension is still under review (i.e. not in draft and not approved).

image.png

34 KiB

image.png

76 KiB

image.png

200 KiB

Patiga commented

2024-09-17 17:36:27 +02:00

As someone who submitted their first Add-on, it confuses me that the status is "Awaiting Changes" in the approval queue.
Can I somehow say that I provided said changes and switch back to "Awaiting review"?

Are the approval steps of an Add-on draft -> awaiting review -> awaiting changes -> approved?

As someone who submitted their first Add-on, it confuses me that the status is "Awaiting Changes" in the approval queue. Can I somehow say that I provided said changes and switch back to "Awaiting review"? Are the approval steps of an Add-on `draft -> awaiting review -> awaiting changes -> approved`?

Oleg-Komarov commented

2024-09-17 19:10:15 +02:00

You should be able to select the "Awaiting Review" status in a dropdown in the comment form:

You have to submit a form with a non-empty message and selected status to change the status.

You should be able to select the "Awaiting Review" status in a dropdown in the comment form: <img width="999" alt="image" src="attachments/814629b2-a3e1-4f76-b229-b8a9b82fcb38"> You have to submit a form with a non-empty message and selected status to change the status.

image.png

77 KiB

Patiga commented

2024-09-18 10:35:05 +02:00

Thanks a lot for your help and the quick responses!
I don't think I would've figured this out on my own without your help.

Thanks a lot for your help and the quick responses! I don't think I would've figured this out on my own without your help.

Oleg-Komarov referenced this issue

2024-09-18 10:40:53 +02:00

Broken/obscure navigation #210

Sign in to join this conversation.