infrastructure
/
extensions-website
4
6
Fork 4
Code Issues 23 Pull Requests 3 Projects Releases Wiki Activity

Support package-specified Extension ID #11

Merged
Dalai Felinto merged 1 commits from dfelinto/extensions-website:handle-id-and-slugs into main 2024-01-26 16:26:32 +01:00
Conversation 0 Commits 1 Files Changed 11 +298 -4
Dalai Felinto commented 2024-01-25 17:33:07 +01:00
Owner
Copy Link
  • Update fake data
  • Migrate data-base (partially)

We check for two cases:

  • For new extensions, the extension_id has to be unique.
  • For new versions, the extension_id has to match.
  • Besides that we test for spaces and hyphens (both not allowed).

Note, the migration of the existing data-base is not 100% because it is
not worth spending time on it. We should flatten out the migration and
reset everyone's fake data soon.

* Update fake data * Migrate data-base (partially) We check for two cases: * For new extensions, the extension_id has to be unique. * For new versions, the extension_id has to match. * Besides that we test for spaces and hyphens (both not allowed). Note, the migration of the existing data-base is not 100% because it is not worth spending time on it. We should flatten out the migration and reset everyone's fake data soon.
Dalai Felinto requested review from Francesco Siddi 2024-01-25 17:33:15 +01:00
Francesco Siddi requested changes 2024-01-26 12:51:29 +01:00
files/validators.py Outdated
@ -30,1 +32,4 @@
)
class ExtensionIDManifestValidator:
Francesco Siddi commented 2024-01-26 12:51:13 +01:00
Owner
Copy Link

Maybe add a plain-text summary of what the validation is meant to accomplish.

Maybe add a plain-text summary of what the validation is meant to accomplish.
Dalai Felinto commented 2024-01-26 15:30:56 +01:00
Author
Owner
Copy Link

Done, there was an oversight on a unittest which is now addressed as well.

Done, there was an oversight on a unittest which is now addressed as well.
dfelinto marked this conversation as resolved
Dalai Felinto changed title from Support package-specified Extension ID to WIP: Support package-specified Extension ID 2024-01-26 15:23:46 +01:00
Dalai Felinto force-pushed handle-id-and-slugs from 67ce3e7114 to a22f4f00b3 2024-01-26 15:30:27 +01:00 Compare
Dalai Felinto changed title from WIP: Support package-specified Extension ID to Support package-specified Extension ID 2024-01-26 15:32:08 +01:00
Francesco Siddi approved these changes 2024-01-26 15:39:59 +01:00
Dalai Felinto force-pushed handle-id-and-slugs from a22f4f00b3 to ee584c559a 2024-01-26 16:26:08 +01:00 Compare
Dalai Felinto merged commit ee584c559a into main 2024-01-26 16:26:32 +01:00
Dalai Felinto deleted branch handle-id-and-slugs 2024-01-26 16:26:32 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Francesco Siddi
Labels
Clear labels   
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Normal
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Type
Breaking
Breaking change that won't be backward compatible

  
Type
Bug
Something is not working

  
Type
Documentation
Documentation changes

  
Type
Enhancement
Improve existing functionality

  
Type
Feature
New functionality

  
Type
Security
This is security issue

  
Type
Testing
Issue or pull request related to testing

No Label
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Type
Breaking
Type
Bug
Type
Documentation
Type
Enhancement
Type
Feature
Type
Security
Type
Testing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/extensions-website#11
No description provided.
Delete Branch "dfelinto/extensions-website:handle-id-and-slugs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?