infrastructure/extensions-website
4
8
Fork 10
Code Issues 20 Pull Requests 2 Projects Releases Wiki Activity

Use a materialized Extension.latest_version field instead of a dynamic property #152

Merged
Oleg-Komarov merged 15 commits from latest-version-field into main 2024-05-27 17:58:56 +02:00
Conversation 0 Commits 15 Files Changed 8 +172 -116
Oleg-Komarov commented 2024-05-27 16:50:51 +02:00
Owner
Copy Link

Original reason for this change is #128: we need an efficient way to query tags of a latest_version.

We could potentially avoid converting this property to a field if we had a proper search engine, but we would still need to define the same explicit triggers for reindexing - i.e. recompute the latest_version change.

This PR also takes a stab at simplifying data flow, but more work is needed to improve the management of is_listed and status fields.

Original reason for this change is #128: we need an efficient way to query tags of a latest_version. We could potentially avoid converting this property to a field if we had a proper search engine, but we would still need to define the same explicit triggers for reindexing - i.e. recompute the latest_version change. This PR also takes a stab at simplifying data flow, but more work is needed to improve the management of `is_listed` and `status` fields.
Oleg-Komarov added 9 commits 2024-05-27 16:50:52 +02:00
Oleg-Komarov added 2 commits 2024-05-27 17:01:16 +02:00
Anna Sirota reviewed 2024-05-27 17:36:44 +02:00
extensions/migrations/0031_extension_latest_version.py
@ -0,0 +29,4 @@
latest_version = version
break
extension.latest_version = latest_version
extension.save(update_fields={'latest_version'})
Anna Sirota commented 2024-05-27 17:22:21 +02:00
Owner
Copy Link

Extension.objects.bulk_update(.., fields={'latest_version'})

`Extension.objects.bulk_update(.., fields={'latest_version'})`
Oleg-Komarov marked this conversation as resolved
extensions/models.py Outdated
@ -415,1 +409,4 @@
@transaction.atomic
def update_latest_version(self, skip_version=None):
versions = self.versions.all().order_by('-date_created')
Anna Sirota commented 2024-05-27 17:24:37 +02:00
Owner
Copy Link

select_related missing for .file

`select_related` missing for `.file`
Oleg-Komarov marked this conversation as resolved
extensions/models.py Outdated
@ -416,0 +429,4 @@
and self.versions.filter(file__status=File.STATUSES.APPROVED).count() > 0
)
# this method is called from post_save signal, this early return above should prevent a loop
Anna Sirota commented 2024-05-27 17:25:43 +02:00
Owner
Copy Link

"below"?

"below"?
Oleg-Komarov marked this conversation as resolved
extensions/tests/test_update.py Outdated
@ -222,3 +222,3 @@
_get_all_form_errors(response),
)
self.assertFalse("TODO: It should also list previews as required")
# self.assertFalse("TODO: It should also list previews as required")
Anna Sirota commented 2024-05-27 17:36:10 +02:00
Owner
Copy Link

should a separate commit, out of scope

should a separate commit, out of scope
Oleg-Komarov marked this conversation as resolved
Oleg-Komarov added 2 commits 2024-05-27 17:48:29 +02:00
Oleg-Komarov added 1 commit 2024-05-27 17:52:56 +02:00
Oleg-Komarov added 1 commit 2024-05-27 17:57:13 +02:00
Anna Sirota approved these changes 2024-05-27 17:58:04 +02:00
Oleg-Komarov merged commit db67d94507 into main 2024-05-27 17:58:56 +02:00
Oleg-Komarov deleted branch latest-version-field 2024-05-27 17:58:56 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Anna Sirota
Labels
Clear labels   
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Normal
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Type
Breaking
Breaking change that won't be backward compatible

  
Type
Documentation
Documentation changes

  
Type
Enhancement
Improve existing functionality

  
Type
Feature
New functionality

  
Type
Report
Something is not working

  
Type
Security
This is security issue

  
Type
Suggestion
New ideas and proposals

  
Type
Testing
Issue or pull request related to testing

No Label
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Type
Breaking
Type
Documentation
Type
Enhancement
Type
Feature
Type
Report
Type
Security
Type
Suggestion
Type
Testing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/extensions-website#152
No description provided.
Delete Branch "latest-version-field"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?