infrastructure/extensions-website
4
8
Fork 10
Code Issues 20 Pull Requests 2 Projects Releases Wiki Activity

Use a materialized Extension.latest_version field instead of a dynamic property #152

Merged
Oleg-Komarov merged 15 commits from latest-version-field into main 2024-05-27 17:58:56 +02:00
Conversation 0 Commits 15 Files Changed 8 +3
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit b42350b4e9 - Show all commits

1
extensions/models.py
View File

@ -429,6 +429,7 @@ class Extension(CreatedModifiedMixin, RatingMixin, TrackChangesMixin, models.Mod
and self.versions.filter(file__status=File.STATUSES.APPROVED).count() > 0 and self.versions.filter(file__status=File.STATUSES.APPROVED).count() > 0
) )
# this method is called from post_save signal, this early return above should prevent a loop
if self.is_listed == should_be_listed: if self.is_listed == should_be_listed:
return return

2
extensions/signals.py
View File

@ -74,6 +74,8 @@ def _update_version(
if hasattr(instance, 'version'): if hasattr(instance, 'version'):
extension = instance.version.extension extension = instance.version.extension
with transaction.atomic(): with transaction.atomic():
# it's important to update is_listed before computing latest_version
# because latest_version for listed and unlisted extensions are defined differently
extension.update_is_listed() extension.update_is_listed()
extension.update_latest_version() extension.update_latest_version()