infrastructure/extensions-website
4
8
Fork 10
Code Issues 20 Pull Requests 2 Projects Releases Wiki Activity

Use a materialized Extension.latest_version field instead of a dynamic property #152

Merged
Oleg-Komarov merged 15 commits from latest-version-field into main 2024-05-27 17:58:56 +02:00
Conversation 0 Commits 15 Files Changed 8 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit bbb7c9fc85 - Show all commits

2
extensions/models.py
View File

@ -409,7 +409,7 @@ class Extension(CreatedModifiedMixin, RatingMixin, TrackChangesMixin, models.Mod
@transaction.atomic @transaction.atomic
def update_latest_version(self, skip_version=None): def update_latest_version(self, skip_version=None):
versions = self.versions.select_related('file').all().order_by('-date_created') versions = self.versions.select_related('file').order_by('-date_created')
Oleg-Komarov marked this conversation as resolved Outdated
Anna Sirota commented 2024-05-27 17:24:37 +02:00
Outdated
Review
Copy Link

select_related missing for .file

`select_related` missing for `.file`
latest_version = None latest_version = None
for version in versions: for version in versions:
if skip_version and version == skip_version: if skip_version and version == skip_version: