infrastructure/extensions-website
4
8
Fork 10
Code Issues 20 Pull Requests 2 Projects Releases Wiki Activity

Version: drop file field, use files instead #193

Merged
Oleg-Komarov merged 6 commits from version-drop-file into main 2024-06-21 11:29:22 +02:00
Conversation 0 Commits 6 Files Changed 16 +136 -88
Oleg-Komarov commented 2024-06-20 20:46:20 +02:00
Owner
Copy Link

Part of #74.

This PR drops Extension.file field, and introduces a cached_property Extension.file
as a temporary replacement for existing code references to the dropped field.

VersionFiles is renamed to VersionFile to match naming conventions.
All reads and writes go only via VersionFile cross-table, still assuming a single File
record per Version.

No functional changes are expected, except for one unfortunate side-effect in
recording object deletion via LogEntry: Version deletion is recorded twice:

  1. during Extension deleting its Version objects via CASCADE
  2. during post_delete for VersionFile when the check for the last file is done

After this change is deployed, we can start implementing multiple file uploads per
Version to support multi-platform builds (generated with --split-platforms option).

Part of #74. This PR drops Extension.file field, and introduces a cached_property Extension.file as a temporary replacement for existing code references to the dropped field. VersionFiles is renamed to VersionFile to match naming conventions. All reads and writes go only via VersionFile cross-table, still assuming a single File record per Version. No functional changes are expected, except for one unfortunate side-effect in recording object deletion via LogEntry: Version deletion is recorded twice: 1. during Extension deleting its Version objects via CASCADE 2. during post_delete for VersionFile when the check for the last file is done After this change is deployed, we can start implementing multiple file uploads per Version to support multi-platform builds (generated with `--split-platforms` option).
Oleg-Komarov added 3 commits 2024-06-20 20:46:21 +02:00
Oleg-Komarov added 1 commit 2024-06-21 10:44:58 +02:00
Oleg-Komarov added 2 commits 2024-06-21 10:58:45 +02:00
Anna Sirota approved these changes 2024-06-21 11:11:44 +02:00
Anna Sirota left a comment
Owner
Copy Link

LGTM

LGTM
Oleg-Komarov merged commit 3922f5d868 into main 2024-06-21 11:29:22 +02:00
Oleg-Komarov deleted branch version-drop-file 2024-06-21 11:29:23 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Anna Sirota
Labels
Clear labels   
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Normal
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Type
Breaking
Breaking change that won't be backward compatible

  
Type
Documentation
Documentation changes

  
Type
Enhancement
Improve existing functionality

  
Type
Feature
New functionality

  
Type
Report
Something is not working

  
Type
Security
This is security issue

  
Type
Suggestion
New ideas and proposals

  
Type
Testing
Issue or pull request related to testing

No Label
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Type
Breaking
Type
Documentation
Type
Enhancement
Type
Feature
Type
Report
Type
Security
Type
Suggestion
Type
Testing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/extensions-website#193
No description provided.
Delete Branch "version-drop-file"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?