infrastructure/extensions-website
4
8
Fork 10
Code Issues 19 Pull Requests 2 Projects Releases Wiki Activity

Consistent hero-tabs navigation #244

Merged
Oleg-Komarov merged 4 commits from hero-tabs into main 2024-09-03 11:55:35 +02:00
Conversation 1 Commits 4 Files Changed 7 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 375bbb1baa - Show all commits

2
extensions/templates/extensions/version_list.html
View File

@ -106,7 +106,7 @@
</section>
<div class="btn-col">
{% if not is_maintainer %}
{% if not is_maintainer and not extension.is_approved %}
<div class="card p-3 mt-3 ext-detail-download-danger">
<h3>Caution</h3>
pablovazquez marked this conversation as resolved
Pablo Vazquez commented 2024-09-03 11:32:01 +02:00
Review
Copy Link

Not sure how is this related to the hero tabs?

Not sure how is this related to the hero tabs?
Oleg-Komarov commented 2024-09-03 11:39:32 +02:00
Review
Copy Link

It relates to this part:

This commit also opens the "Version History" page for everyone

and the caution card is needed because if we decide to show "Version History" to everyone, we should the same warning as on the approval queue detail page.

Otherwise we should add more complicated checks to "Version History" display condition, and I think it's simpler and more useful to always show it.

It relates to this part: > This commit also opens the "Version History" page for everyone and the caution card is needed because if we decide to show "Version History" to everyone, we should the same warning as on the approval queue detail page. Otherwise we should add more complicated checks to "Version History" display condition, and I think it's simpler and more useful to always show it.
<p>