Consistent hero-tabs navigation #244

Merged
Oleg-Komarov merged 4 commits from hero-tabs into main 2024-09-03 11:55:35 +02:00
Owner

see #210

Build the tab list on backend, independent of the template that includes them.
This ensures consistency between page transitions and avoids linking to pages
resulting in 404.

This commit also opens the "Version History" page for everyone, to make it
consistent with the logic that shows approval queue detail page to everyone.

see #210 Build the tab list on backend, independent of the template that includes them. This ensures consistency between page transitions and avoids linking to pages resulting in 404. This commit also opens the "Version History" page for everyone, to make it consistent with the logic that shows approval queue detail page to everyone.
Oleg-Komarov added 1 commit 2024-09-02 13:17:42 +02:00
see #210

Build the tab list on backend, independent of the template that includes them.
This ensures consistency between page transitions and avoids linking to pages
resulting in 404.

This commit also opens the "Version History" page for everyone, to make it
consistent with the logic that shows approval queue detail page to everyone.
Author
Owner

@pablovazquez could you please take a look, if this makes sense overall, and if the templatetag implementation is clear

@pablovazquez could you please take a look, if this makes sense overall, and if the templatetag implementation is clear
Oleg-Komarov added 1 commit 2024-09-02 13:22:40 +02:00
Oleg-Komarov added 1 commit 2024-09-02 13:22:55 +02:00
Pablo Vazquez reviewed 2024-09-03 11:33:16 +02:00
Pablo Vazquez left a comment
Owner

Hi! Can't test right now but having a quick look at the PR I noticed there is a change in version_list.html that I don't see a relation with the hero tabs.

But other than that it's super nice, easy to read and expand. Thanks!

Hi! Can't test right now but having a quick look at the PR I noticed there is a change in `version_list.html` that I don't see a relation with the hero tabs. But other than that it's super nice, easy to read and expand. Thanks!
@ -111,1 +108,4 @@
<div class="btn-col">
{% if not is_maintainer and not extension.is_approved %}
<div class="card p-3 mt-3 ext-detail-download-danger">
<h3>Caution</h3>

Not sure how is this related to the hero tabs?

Not sure how is this related to the hero tabs?
Author
Owner

It relates to this part:

This commit also opens the "Version History" page for everyone

and the caution card is needed because if we decide to show "Version History" to everyone, we should the same warning as on the approval queue detail page.

Otherwise we should add more complicated checks to "Version History" display condition, and I think it's simpler and more useful to always show it.

It relates to this part: > This commit also opens the "Version History" page for everyone and the caution card is needed because if we decide to show "Version History" to everyone, we should the same warning as on the approval queue detail page. Otherwise we should add more complicated checks to "Version History" display condition, and I think it's simpler and more useful to always show it.
pablovazquez marked this conversation as resolved
Pablo Vazquez approved these changes 2024-09-03 11:52:21 +02:00
Pablo Vazquez left a comment
Owner

Looks good. Thanks!

Looks good. Thanks!
Oleg-Komarov added 1 commit 2024-09-03 11:55:17 +02:00
Oleg-Komarov merged commit 0b18fa672b into main 2024-09-03 11:55:35 +02:00
Oleg-Komarov deleted branch hero-tabs 2024-09-03 11:55:35 +02:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/extensions-website#244
No description provided.