Consistent hero-tabs navigation #244
No reviewers
Labels
No Label
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Type
Breaking
Type
Documentation
Type
Enhancement
Type
Feature
Type
Report
Type
Security
Type
Suggestion
Type
Testing
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: infrastructure/extensions-website#244
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "hero-tabs"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
see #210
Build the tab list on backend, independent of the template that includes them.
This ensures consistency between page transitions and avoids linking to pages
resulting in 404.
This commit also opens the "Version History" page for everyone, to make it
consistent with the logic that shows approval queue detail page to everyone.
@pablovazquez could you please take a look, if this makes sense overall, and if the templatetag implementation is clear
Hi! Can't test right now but having a quick look at the PR I noticed there is a change in
version_list.html
that I don't see a relation with the hero tabs.But other than that it's super nice, easy to read and expand. Thanks!
@ -111,1 +108,4 @@
<div class="btn-col">
{% if not is_maintainer and not extension.is_approved %}
<div class="card p-3 mt-3 ext-detail-download-danger">
<h3>Caution</h3>
Not sure how is this related to the hero tabs?
It relates to this part:
and the caution card is needed because if we decide to show "Version History" to everyone, we should the same warning as on the approval queue detail page.
Otherwise we should add more complicated checks to "Version History" display condition, and I think it's simpler and more useful to always show it.
Looks good. Thanks!