infrastructure/extensions-website
4
8
Fork 10
Code Issues 20 Pull Requests 2 Projects Releases Wiki Activity

Consistent hero-tabs navigation #244

Merged
Oleg-Komarov merged 4 commits from hero-tabs into main 2024-09-03 11:55:35 +02:00
Conversation 1 Commits 4 Files Changed 7 +74 -55
Oleg-Komarov commented 2024-09-02 13:17:40 +02:00
Owner
Copy Link

see #210

Build the tab list on backend, independent of the template that includes them.
This ensures consistency between page transitions and avoids linking to pages
resulting in 404.

This commit also opens the "Version History" page for everyone, to make it
consistent with the logic that shows approval queue detail page to everyone.

see #210 Build the tab list on backend, independent of the template that includes them. This ensures consistency between page transitions and avoids linking to pages resulting in 404. This commit also opens the "Version History" page for everyone, to make it consistent with the logic that shows approval queue detail page to everyone.
Oleg-Komarov added 1 commit 2024-09-02 13:17:42 +02:00 
see #210

Build the tab list on backend, independent of the template that includes them.
This ensures consistency between page transitions and avoids linking to pages
resulting in 404.

This commit also opens the "Version History" page for everyone, to make it
consistent with the logic that shows approval queue detail page to everyone.
Oleg-Komarov commented 2024-09-02 13:19:01 +02:00
Author
Owner
Copy Link

@pablovazquez could you please take a look, if this makes sense overall, and if the templatetag implementation is clear

@pablovazquez could you please take a look, if this makes sense overall, and if the templatetag implementation is clear
Oleg-Komarov added 1 commit 2024-09-02 13:22:40 +02:00
Oleg-Komarov added 1 commit 2024-09-02 13:22:55 +02:00
Pablo Vazquez reviewed 2024-09-03 11:33:16 +02:00
Pablo Vazquez left a comment
Owner
Copy Link

Hi! Can't test right now but having a quick look at the PR I noticed there is a change in version_list.html that I don't see a relation with the hero tabs.

But other than that it's super nice, easy to read and expand. Thanks!

Hi! Can't test right now but having a quick look at the PR I noticed there is a change in `version_list.html` that I don't see a relation with the hero tabs. But other than that it's super nice, easy to read and expand. Thanks!
extensions/templates/extensions/version_list.html
@ -111,1 +108,4 @@
<div class="btn-col">
{% if not is_maintainer and not extension.is_approved %}
<div class="card p-3 mt-3 ext-detail-download-danger">
<h3>Caution</h3>
Pablo Vazquez commented 2024-09-03 11:32:01 +02:00
Owner
Copy Link

Not sure how is this related to the hero tabs?

Not sure how is this related to the hero tabs?
Oleg-Komarov commented 2024-09-03 11:39:32 +02:00
Author
Owner
Copy Link

It relates to this part:

This commit also opens the "Version History" page for everyone

and the caution card is needed because if we decide to show "Version History" to everyone, we should the same warning as on the approval queue detail page.

Otherwise we should add more complicated checks to "Version History" display condition, and I think it's simpler and more useful to always show it.

It relates to this part: > This commit also opens the "Version History" page for everyone and the caution card is needed because if we decide to show "Version History" to everyone, we should the same warning as on the approval queue detail page. Otherwise we should add more complicated checks to "Version History" display condition, and I think it's simpler and more useful to always show it.
pablovazquez marked this conversation as resolved
Pablo Vazquez approved these changes 2024-09-03 11:52:21 +02:00
Pablo Vazquez left a comment
Owner
Copy Link

Looks good. Thanks!

Looks good. Thanks!
Oleg-Komarov added 1 commit 2024-09-03 11:55:17 +02:00
Oleg-Komarov merged commit 0b18fa672b into main 2024-09-03 11:55:35 +02:00
Oleg-Komarov deleted branch hero-tabs 2024-09-03 11:55:35 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Pablo Vazquez
Labels
Clear labels   
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Normal
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Type
Breaking
Breaking change that won't be backward compatible

  
Type
Documentation
Documentation changes

  
Type
Enhancement
Improve existing functionality

  
Type
Feature
New functionality

  
Type
Report
Something is not working

  
Type
Security
This is security issue

  
Type
Suggestion
New ideas and proposals

  
Type
Testing
Issue or pull request related to testing

No Label
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Type
Breaking
Type
Documentation
Type
Enhancement
Type
Feature
Type
Report
Type
Security
Type
Suggestion
Type
Testing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/extensions-website#244
No description provided.
Delete Branch "hero-tabs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?