infrastructure
/
extensions-website
4
6
Fork 4
Code Issues 23 Pull Requests 3 Projects Releases Wiki Activity

Manifest: New field "permission" #26

Closed
Dalai Felinto wants to merge 1 commits from dfelinto:permissions into main
pull from: dfelinto:permissions
merge into: infrastructure:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 1 Commits 1 Files Changed 11 +247 -16
Dalai Felinto commented 2024-02-16 18:54:08 +01:00
Owner
Copy Link

Support the following permissions:

  • 'files'
  • 'network'

The Front-End implementation of permissions is planned as a separate
task (by the Front-End team ;).

Support the following permissions: * 'files' * 'network' The Front-End implementation of permissions is planned as a separate task (by the Front-End team ;).
Dalai Felinto added 1 commit 2024-02-16 18:54:10 +01:00
c255eeb0a1 Manifest: New field "permission" 
Support the following permissions:
* 'files'
* 'network'

The Front-End implementation of permissions is planned as a separate
task (by the Front-End team ;).
Dalai Felinto requested review from Francesco Siddi 2024-02-16 18:54:36 +01:00
Francesco Siddi approved these changes 2024-02-17 15:47:36 +01:00
Francesco Siddi left a comment
Owner
Copy Link

It all looks good. Just make sure it's clearly documented that "permissions" are simply a indication of what the add-on might do. Further:

  • developers can omit this information
  • there is no enforcement of the permission
It all looks good. Just make sure it's clearly documented that "permissions" are simply a indication of what the add-on might do. Further: - developers can omit this information - there is no enforcement of the permission
Dalai Felinto commented 2024-02-19 09:44:03 +01:00
Author
Owner
Copy Link

Implemented as cb4e29ecf3

Implemented as cb4e29ecf34a3e7bbf23cff63b48c1403362bba4
Dalai Felinto closed this pull request 2024-02-19 09:44:04 +01:00
Dalai Felinto deleted branch permissions 2024-02-19 09:44:09 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Francesco Siddi
Labels
Clear labels   
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Normal
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Type
Breaking
Breaking change that won't be backward compatible

  
Type
Bug
Something is not working

  
Type
Documentation
Documentation changes

  
Type
Enhancement
Improve existing functionality

  
Type
Feature
New functionality

  
Type
Security
This is security issue

  
Type
Testing
Issue or pull request related to testing

No Label
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Type
Breaking
Type
Bug
Type
Documentation
Type
Enhancement
Type
Feature
Type
Security
Type
Testing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/extensions-website#26
No description provided.
Delete Branch "dfelinto:permissions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?