infrastructure
/
extensions-website
4
6
Fork 4
Code Issues 23 Pull Requests 3 Projects Releases Wiki Activity

UI: Make preview images ratio fixed #28

Merged
Márton Lente merged 3 commits from martonlente/extensions-website:ui-images-preview into main 2024-02-20 18:05:50 +01:00
Conversation 2 Commits 3 Files Changed 4 +21 -15
Márton Lente commented 2024-02-20 11:04:49 +01:00
Owner
Copy Link

Part of #27

This pull request makes cards' preview images' aspect ratio 16:9. The preview images are shown in their 16:9 containers, aligned to the center, filling the container size, no matter the images' physical size.

Part of #27 This pull request makes cards' preview images' aspect ratio 16:9. The preview images are shown in their 16:9 containers, aligned to the center, filling the container size, no matter the images' physical size.
Márton Lente added 1 commit 2024-02-20 11:04:51 +01:00
Dalai Felinto commented 2024-02-20 12:56:26 +01:00
Owner
Copy Link

This seems to be working. However the mini preview card is broken with it:

image

This seems to be working. However the mini preview card is broken with it: ![image](/attachments/4400b1d3-30bb-4f61-ada5-bc966ad29c5f)
image.png
64 KiB
non_aspect.png
42 KiB
non_aspect.png
Dalai Felinto commented 2024-02-20 13:00:35 +01:00
Owner
Copy Link

And even if we are smart and do what this patch does, I think we should still hint/tell the users to favor 16:9 images (or whatever aspect ration you are reinforcing).

And even if we are smart and do what this patch does, I think we should still hint/tell the users to favor 16:9 images (or whatever aspect ration you are reinforcing).
Márton Lente added 1 commit 2024-02-20 14:33:12 +01:00
Márton Lente added 1 commit 2024-02-20 14:40:31 +01:00
Dalai Felinto approved these changes 2024-02-20 17:57:57 +01:00
Dalai Felinto left a comment
Owner
Copy Link

LGTM

LGTM
Márton Lente merged commit 3fc794bbf9 into main 2024-02-20 18:05:50 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Dalai Felinto
Labels
Clear labels   
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Normal
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Type
Breaking
Breaking change that won't be backward compatible

  
Type
Bug
Something is not working

  
Type
Documentation
Documentation changes

  
Type
Enhancement
Improve existing functionality

  
Type
Feature
New functionality

  
Type
Security
This is security issue

  
Type
Testing
Issue or pull request related to testing

No Label
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Type
Breaking
Type
Bug
Type
Documentation
Type
Enhancement
Type
Feature
Type
Security
Type
Testing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/extensions-website#28
No description provided.
Delete Branch "martonlente/extensions-website:ui-images-preview"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?