infrastructure
/
extensions-website
4
6
Fork 4
Code Issues 23 Pull Requests 3 Projects Releases Wiki Activity

UI: Improve Review queue list and details pages' UIs #33

Manually merged
Márton Lente merged 15 commits from martonlente/extensions-website:ui-review-queue into main 2024-02-22 15:29:32 +01:00
Conversation 0 Commits 15 Files Changed 6 +286 -57
Márton Lente commented 2024-02-20 22:11:33 +01:00
Owner
Copy Link

This PR will improve Review queue list and detail pages' UIs. Review queue templates reuse existing UI elements and patterns from other templates, and can be cohesively improved further.

List page

  • Shows items to be reviewed in a table format
  • Shows status badges with conditional warning, danger or success colours accordingly

Screenshot

Review queue UI page list

Detail page

  • Shows item details in a similar layout and style as extensions detail pages
  • Shows preview images conditionally
  • Shows activity log in a similar style as extensions detail pages' Review tab. 'Status change' activity log items are displayed with subtle differences and text content
  • Shows 'Add activity' form. Activity form's textarea field is conditionally hidden, if selected activity type is not Comment

Screenshot

Review queue UI page detail

The following work-in-progress todos have been completed:
  • Cleanup: Remove todos and placeholders
  • Detail page: Activity section activity list UI improvements
  • Detail page: Activity section review comment form UI improvements
  • PR: Screenshots for both the list and detail pages
  • Other markdown rendering issues, that will also improve other templates' UI
This PR will improve Review queue list and detail pages' UIs. Review queue templates reuse existing UI elements and patterns from other templates, and can be cohesively improved further. ## List page - Shows items to be reviewed in a table format - Shows status badges with conditional warning, danger or success colours accordingly ### Screenshot ![Review queue UI page list](https://projects.blender.org/attachments/74f8f89f-7b95-4002-a643-a7c5394f557c) ## Detail page - Shows item details in a similar layout and style as extensions detail pages - Shows preview images conditionally - Shows activity log in a similar style as extensions detail pages' Review tab. 'Status change' activity log items are displayed with subtle differences and text content - Shows 'Add activity' form. Activity form's textarea field is conditionally hidden, if selected activity type is not _Comment_ ### Screenshot ![Review queue UI page detail](https://projects.blender.org/attachments/7593a499-2c65-411a-a5f4-d612fdbbc641) ###### The following work-in-progress todos have been completed: - [x] Cleanup: Remove todos and placeholders - [x] Detail page: Activity section activity list UI improvements - [x] Detail page: Activity section review comment form UI improvements - [x] PR: Screenshots for both the list and detail pages - [ ] Other markdown rendering issues, that will also improve other templates' UI
review-queue-ui-page-list-cropped.png
57 KiB
review-queue-ui-page-detail-cropped.png
598 KiB
Márton Lente added 4 commits 2024-02-20 22:11:36 +01:00
Márton Lente added 1 commit 2024-02-20 22:46:19 +01:00
Márton Lente added 1 commit 2024-02-22 09:45:02 +01:00
Márton Lente added 1 commit 2024-02-22 10:24:58 +01:00
Márton Lente added 1 commit 2024-02-22 10:52:47 +01:00
Márton Lente added 1 commit 2024-02-22 11:01:00 +01:00
Márton Lente added 1 commit 2024-02-22 11:06:38 +01:00
Márton Lente added 1 commit 2024-02-22 11:07:51 +01:00
Márton Lente changed title from WIP: Improve Review queue list and details pages' UIs to UI: Improve Review queue list and details pages' UIs 2024-02-22 11:40:14 +01:00
Márton Lente added 1 commit 2024-02-22 12:05:38 +01:00
Márton Lente added 1 commit 2024-02-22 12:10:45 +01:00
Márton Lente added 1 commit 2024-02-22 12:55:22 +01:00
Márton Lente added 1 commit 2024-02-22 14:01:17 +01:00
Pablo Vazquez approved these changes 2024-02-22 14:09:46 +01:00
Márton Lente manually merged commit da6158a885 into main 2024-02-22 15:29:32 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Pablo Vazquez
Labels
Clear labels   
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Normal
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Type
Breaking
Breaking change that won't be backward compatible

  
Type
Bug
Something is not working

  
Type
Documentation
Documentation changes

  
Type
Enhancement
Improve existing functionality

  
Type
Feature
New functionality

  
Type
Security
This is security issue

  
Type
Testing
Issue or pull request related to testing

No Label
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Type
Breaking
Type
Bug
Type
Documentation
Type
Enhancement
Type
Feature
Type
Security
Type
Testing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/extensions-website#33
No description provided.
Delete Branch "martonlente/extensions-website:ui-review-queue"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?