Draft: Make sure extensions always have a user #54
No reviewers
Labels
No Label
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Type
Breaking
Type
Documentation
Type
Enhancement
Type
Feature
Type
Report
Type
Security
Type
Suggestion
Type
Testing
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: infrastructure/extensions-website#54
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "dfelinto/extensions-website:fix-no-orphans"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
When submitting a file the created extension gets a user right away.
This makes sure there are no orphans extensions.
The extension is then incomplete until the draft is saved once (which
means finalizing the extension upload process, by adding a description
and thumbnails).
Any attempt to edit or submit a new extension will lead the user to the
editing draft page.
Note: We could add a new option to [x] Send for Review. The front-end
even has a half-baked code for that. But should be tackled separately.
Patch notes:
The current approach tries to return the SubmitFileView view when editing an incomplete extension. It is not working (403).
I think the best course of action is:
b95ed0cb98
tobaf67fc9c0
WIP: New Extensions should get a user right awayto Draft: Make sure extensions always have a userCode should be good now.
I still need to fix unittests though (since some were testing the finalize-submit URL which no longer exists).donebaf67fc9c0
to489da73683
Just noticed that if I as a maintainer got more than one extension (one a freshly uploaded draft, another already in approval queue, for example), then it's impossible to edit the other extension.
Is this also intentional?
Or should be at least allow editing the already existing extension?
Editing existing extensions should be allowed, regardless of a pending one. The current behavior looks like a bug/limitation.
A bug indeed. The only thing which should be prevented is to upload a new extension while there is a draft still around.
Pushed a fix for this in
725d03589a