Extra validation of the uploaded ZIP #73

Anna Sirota · 2024-04-08T19:27:14+02:00

Anna Sirota commented

2024-04-08 19:27:14 +02:00

Part of #70 and should cover the following list:

Surface the errors from the .zip extraction code (read_manifest_from_zip)
Check for __init__.py when the .zip contains a folder.
Allow only a single theme (.xml) per .zip

What changed

The following is now reported as validation errors on extension archive upload:

missing manifest file
manifest file nested deeper than one level inside the archive
invalid TOML inside the manifest file
extension-type specific:
- add-on missing a __init__.py file
- theme having multiple XML files instead only one

Part of https://projects.blender.org/infrastructure/extensions-website/issues/70 and should cover the following list: - [x] Surface the errors from the .zip extraction code (read_manifest_from_zip) - [x] Check for `__init__.py` when the .zip contains a folder. - [x] Allow only a single theme (.xml) per .zip ### What changed The following is now reported as validation errors on extension archive upload: * missing manifest file * manifest file nested deeper than one level inside the archive * invalid TOML inside the manifest file * extension-type specific: * add-on missing a `__init__.py` file * theme having multiple XML files instead only one ![one](https://projects.blender.org/attachments/c501095e-f8d2-4425-8d92-a8c74afe5f96) ![two](https://projects.blender.org/attachments/f73fe47b-f390-416e-bbf3-ae9686e5cfc0)

2024-04-09-184313_1084x721_scrot.png

70 KiB

2024-04-09-184329_1087x691_scrot.png

63 KiB

Anna Sirota added the

Type

Enhancement

label 2024-04-08 19:27:14 +02:00

Anna Sirota added 2 commits 2024-04-08 19:27:16 +02:00

d3ebe2e371 Tests: expect a validation error when a theme has multiple XMLs

829145c2e1 Fix a typo, rephrase the util func

Anna Sirota added 1 commit 2024-04-09 10:25:13 +02:00