infrastructure
/
extensions-website
4
6
Fork 4
Code Issues 23 Pull Requests 3 Projects Releases Wiki Activity

Fix #1: Source size not shown on uploading extension #8

Merged
Dalai Felinto merged 1 commits from dfelinto/extensions-website:fix-source-size into main 2024-01-09 11:09:40 +01:00
Conversation 0 Commits 1 Files Changed 1 +6 -3
Dalai Felinto commented 2024-01-08 16:51:36 +01:00
Owner
Copy Link

The error was:

  • Missing f, before f''.
  • Not dividing the size to MBs before showing.

The fix went a bit further and is accepting uploaded files up to <11MB.

That makes the error message simpler to understand. Otherwise a file
which was 10.0001MB would trigger the error, yet we wouldn't want to
expose this level of detail to users. So now the error will only show up
when the file is at least 11MB, and we can stick to showing integers.

The error was: * Missing f, before f''. * Not dividing the size to MBs before showing. The fix went a bit further and is accepting uploaded files up to <11MB. That makes the error message simpler to understand. Otherwise a file which was 10.0001MB would trigger the error, yet we wouldn't want to expose this level of detail to users. So now the error will only show up when the file is at least 11MB, and we can stick to showing integers.
👍 1
Dalai Felinto requested review from Francesco Siddi 2024-01-08 16:51:45 +01:00
Francesco Siddi approved these changes 2024-01-09 10:41:21 +01:00
Dalai Felinto force-pushed fix-source-size from bf125edcdd to 885aae59f2 2024-01-09 11:06:30 +01:00 Compare
Dalai Felinto force-pushed fix-source-size from 885aae59f2 to 5cc0f19ffa 2024-01-09 11:09:20 +01:00 Compare
Dalai Felinto merged commit 9f8334e8f1 into main 2024-01-09 11:09:40 +01:00
Dalai Felinto deleted branch fix-source-size 2024-01-09 11:09:41 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Francesco Siddi
Labels
Clear labels   
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Normal
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Type
Breaking
Breaking change that won't be backward compatible

  
Type
Bug
Something is not working

  
Type
Documentation
Documentation changes

  
Type
Enhancement
Improve existing functionality

  
Type
Feature
New functionality

  
Type
Security
This is security issue

  
Type
Testing
Issue or pull request related to testing

No Label
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Type
Breaking
Type
Bug
Type
Documentation
Type
Enhancement
Type
Feature
Type
Security
Type
Testing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/extensions-website#8
No description provided.
Delete Branch "dfelinto/extensions-website:fix-source-size"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?