infrastructure/extensions-website
4
8
Fork 10
Code Issues 20 Pull Requests 2 Projects Releases Wiki Activity

Make it possible to fully delete unlisted/unrated extensions #81

Merged
Anna Sirota merged 24 commits from fully-delete-extension into main 2024-04-19 11:00:19 +02:00
Conversation 0 Commits 24 Files Changed 32 +400 -266
Anna Sirota commented 2024-04-15 19:36:42 +02:00
Owner
Copy Link
  • removes all soft-deletion;
  • shows a "Delete extension" button on the draft page in case it can be deleted;
  • shows a "Delete version" button on the version page in case it can be deleted;
  • a version can be deleted if
    • its file isn't approved, and it doesn't have any ratings;
  • an extension can be deleted if
    • it's not listed, and doesn't have any ratings or abuse reports;
    • all it's versions can also be deleted;
  • changes default File.status from APPROVED to AWAITING_REVIEW
    With version's file status being APPROVED by default, a version can never be deleted, even when the extension is still a draft.
    This change doesn't affect the approval process because
    • when an extension is approved its latest version becomes approved automatically (no change here);
    • when a new version is uploaded to an approved extension, it's approved automatically (this is new).

This allows authors to delete their drafts, freeing the extension slug and making it possible to re-upload the same file.
This also makes it possible to easily fix mistakes during the drafting of a new extension (e.g. delete a version and re-upload it without bumping a version for each typo/mistake in packaging and so on).
(see #78 and #63)

* removes all soft-deletion; * shows a "Delete extension" button on the draft page in case it can be deleted; * shows a "Delete version" button on the version page in case it can be deleted; * a version can be deleted if * its file isn't approved, and it doesn't have any ratings; * an extension can be deleted if * it's not listed, and doesn't have any ratings or abuse reports; * all it's versions can also be deleted; * changes default `File.status` from `APPROVED` to `AWAITING_REVIEW` With version's file status being `APPROVED` by default, a version can never be deleted, even when the extension is still a draft. This change doesn't affect the approval process because * when an extension is approved its latest version becomes approved automatically (no change here); * when a new version is uploaded to an approved extension, it's approved automatically (this is new). This allows authors to delete their drafts, freeing the extension slug and making it possible to re-upload the same file. This also makes it possible to easily fix mistakes during the drafting of a new extension (e.g. delete a version and re-upload it without bumping a version for each typo/mistake in packaging and so on). (see https://projects.blender.org/infrastructure/extensions-website/issues/78 and https://projects.blender.org/infrastructure/extensions-website/issues/63)
Anna Sirota added 3 commits 2024-04-15 19:36:45 +02:00
Anna Sirota added 1 commit 2024-04-16 20:03:37 +02:00
Anna Sirota added 1 commit 2024-04-16 20:06:33 +02:00
Anna Sirota added 1 commit 2024-04-18 11:00:34 +02:00
Anna Sirota added 1 commit 2024-04-18 11:52:22 +02:00
Anna Sirota added 4 commits 2024-04-18 12:28:27 +02:00
Anna Sirota added 5 commits 2024-04-18 15:13:21 +02:00
Anna Sirota added 1 commit 2024-04-18 15:14:13 +02:00
Anna Sirota added 2 commits 2024-04-18 16:19:55 +02:00
Anna Sirota added 1 commit 2024-04-18 17:15:33 +02:00
Anna Sirota added 1 commit 2024-04-18 18:38:36 +02:00
Anna Sirota added 1 commit 2024-04-18 19:03:25 +02:00
Anna Sirota changed title from WIP: Make it possible to fully delete unlisted/unrated extensions to Make it possible to fully delete unlisted/unrated extensions 2024-04-18 19:03:35 +02:00
Anna Sirota added 2 commits 2024-04-19 10:29:27 +02:00
Anna Sirota merged commit caae613747 into main 2024-04-19 11:00:19 +02:00
Anna Sirota deleted branch fully-delete-extension 2024-04-19 11:00:19 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Normal
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Type
Breaking
Breaking change that won't be backward compatible

  
Type
Documentation
Documentation changes

  
Type
Enhancement
Improve existing functionality

  
Type
Feature
New functionality

  
Type
Report
Something is not working

  
Type
Security
This is security issue

  
Type
Suggestion
New ideas and proposals

  
Type
Testing
Issue or pull request related to testing

No Label
Priority
Critical
Priority
High
Priority
Low
Priority
Normal
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Type
Breaking
Type
Documentation
Type
Enhancement
Type
Feature
Type
Report
Type
Security
Type
Suggestion
Type
Testing
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/extensions-website#81
No description provided.
Delete Branch "fully-delete-extension"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?