infrastructure/extensions-website
4
8
Fork 10
Code Issues 20 Pull Requests 2 Projects Releases Wiki Activity

Make it possible to fully delete unlisted/unrated extensions #81

Merged
Anna Sirota merged 24 commits from fully-delete-extension into main 2024-04-19 11:00:19 +02:00
Conversation 0 Commits 24 Files Changed 32 +3 -6
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit f3205d4429 - Show all commits

5
extensions/views/manage.py
View File

@ -361,8 +361,9 @@ class DraftExtensionView(
def get_initial(self): def get_initial(self):
"""Return initial values for the version, based on the file.""" """Return initial values for the version, based on the file."""
initial = super().get_initial() initial = super().get_initial()
initial['file'] = self.version.file if self.version:
initial.update(**self.version.file.parsed_version_fields) initial['file'] = self.version.file
initial.update(**self.version.file.parsed_version_fields)
return initial return initial
def get_context_data(self, form=None, extension_form=None, add_preview_formset=None, **kwargs): def get_context_data(self, form=None, extension_form=None, add_preview_formset=None, **kwargs):

4
extensions/views/mixins.py
View File

@ -1,6 +1,5 @@
from django.contrib.auth.mixins import UserPassesTestMixin from django.contrib.auth.mixins import UserPassesTestMixin
from django.shortcuts import get_object_or_404, redirect from django.shortcuts import get_object_or_404, redirect
from django.core.exceptions import BadRequest
from extensions.models import Extension from extensions.models import Extension
from files.models import File from files.models import File
@ -60,9 +59,6 @@ class DraftVersionMixin:
def dispatch(self, *args, **kwargs): def dispatch(self, *args, **kwargs):
self.version = self.extension.versions.first() self.version = self.extension.versions.first()
if self.version is None:
error_message = f'Extension "{self.extension.name}" has no versions.'
raise BadRequest(error_message)
return super().dispatch(*args, **kwargs) return super().dispatch(*args, **kwargs)