infrastructure/web-assets
1
3
Fork 2
Code Issues 3 Pull Requests Projects Releases 29 Wiki Activity

Fix: use '0' instead of 'none' for width property #94689

Merged
Pablo Vazquez merged 1 commits from Blendify/web-assets:fix-sass-warnings into main 2023-06-26 11:09:51 +02:00
Conversation 0 Commits 1 Files Changed 1 +1 -1
Aaron Carlisle commented 2023-06-25 23:31:09 +02:00
Contributor
Copy Link

This variable is used in CSS calculations, using 'none' results in sass warnings.

This commit fixes 6 warnings.

This variable is used in CSS calculations, using 'none' results in sass warnings. This commit fixes 6 warnings.
👍 1
Aaron Carlisle added 1 commit 2023-06-25 23:31:10 +02:00 
This variable is used in CSS calculations, using 'none' results in sass warnings.

This commit fixes 6 warnings.
Aaron Carlisle requested review from Pablo Vazquez 2023-06-25 23:31:21 +02:00
Pablo Vazquez approved these changes 2023-06-26 11:09:29 +02:00
Pablo Vazquez left a comment
Owner
Copy Link

Thanks!

On a side note, I don't think we have any b.org site that uses popovers, so this whole module could probably be removed at some point (and if needed, brought back simpler).

Thanks! On a side note, I don't think we have any b.org site that uses popovers, so this whole module could probably be removed at some point (and if needed, brought back simpler).
Pablo Vazquez merged commit 767c05d7cc into main 2023-06-26 11:09:51 +02:00
Pablo Vazquez deleted branch fix-sass-warnings 2023-06-26 11:09:51 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Pablo Vazquez
Labels
Clear labels   
legacy project
Infrastructure: Blender Web Assets

  
legacy project
Infrastructure: Websites

  
Priority
High

  
Priority
Normal

  
Status
Archived

  
Status
Resolved

  
Type
Design

  
Type
Report

  
Type
To Do

No Label
legacy project
Infrastructure: Blender Web Assets
legacy project
Infrastructure: Websites
Priority
High
Priority
Normal
Status
Archived
Status
Resolved
Type
Design
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: infrastructure/web-assets#94689
No description provided.
Delete Branch "Blendify/web-assets:fix-sass-warnings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?