iss/blender
0
0
Fork 0
forked from blender/blender
Code Pull Requests Activity

VSE: Add sound strip retiming support #2

Closed
Richard Antalik wants to merge 1 commits from retiming-sound into retiming-tool
pull from: retiming-sound
merge into: iss:retiming-tool

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 0 Commits 1 Files Changed 22 +238 -28
Richard Antalik commented 2023-02-17 01:33:44 +01:00
Owner
Copy Link

This patch contains changes needed for retiming sound strips. This is a part of blender/blender#104544

Deviation from blender/blender#100337 is, that changes in audaspace are not separated.
Versioning for old files is not present, because resulting data is unusable (whole animation is baked, so changing retiming is basically impossible). Versioning also results in precision issues which results in non uniform sound pitch in some cases. And finally calculating strip offset correction is non-trivial (that is least of an issue, but worth mentioning still). So I would advocate to not convert old data to current implementation. I think, that supporting smooth speed transitions would allow for more efficient versioning code.

This patch contains changes needed for retiming sound strips. This is a part of blender/blender#104544 ---- Deviation from blender/blender#100337 is, that changes in audaspace are not separated. Versioning for old files is not present, because resulting data is unusable (whole animation is baked, so changing retiming is basically impossible). Versioning also results in precision issues which results in non uniform sound pitch in some cases. And finally calculating strip offset correction is non-trivial (that is least of an issue, but worth mentioning still). So I would advocate to not convert old data to current implementation. I think, that supporting smooth speed transitions would allow for more efficient versioning code.
Richard Antalik added 1 commit 2023-02-17 01:33:53 +01:00 
This patch contains changes needed for retiming sound strips. This is a part of #104544

----

Deviation from #100337 is, that changes in audaspace are not separated.
Versioning for old files is not present, because resulting data is unusable (whole animation is baked, so changing retiming is basically impossible). Versioning also results in precision issues which results in non uniform sound pitch in some cases. And finally calculating strip offset correction is non-trivial (that is least of an issue, but worth mentioning still). So I would advocate to not convert old data to current implementation. I think, that supporting smooth speed transitions would allow for more efficient versioning code.
Richard Antalik closed this pull request 2023-02-23 15:05:08 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: iss/blender#2
No description provided.
Delete Branch "retiming-sound"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?