Richard Antalik iss
  • Joined on 2018-06-01
Richard Antalik commented on issue blender/blender#108810 2023-07-05 00:49:16 +02:00
Problems due to leftover Nvidia drivers

I have swapped GPU for RX550 without touching nvidia drivers and everything runs well. So there is probably some nuance in how this issue is triggered.

Richard Antalik commented on issue blender/blender#109320 2023-07-04 04:37:33 +02:00
Crash when using Menu-Search (F3) --Intel MacOS--

I've got crash after moving mouse after some time. Will try to find steps to reproduce.

Richard Antalik commented on issue blender/blender#109243 2023-07-04 04:33:17 +02:00
Crash when enabling Material Preview viewport shading for model with many materials and PNG textures

According to system info, your GPU driver is at least 2 years old. You can definitely get newer one.

Richard Antalik commented on issue blender/blender#109579 2023-07-04 04:26:00 +02:00
VSE: Changes in F-curve noise modifier are not shown

Will classify as known issue, since there are more instances of curve data not updating sequencer cache.

Richard Antalik pushed to main at blender/blender 2023-07-04 03:55:51 +02:00
9cd07da339 Fix VSE subtitle export indexing
Richard Antalik merged pull request blender/blender#107997 2023-07-04 03:55:51 +02:00
Fix: SubRip subtitle export - sequence numbers now start at 1
Richard Antalik pushed to subrip-1-indexed at Alice-Scarlett/blender 2023-07-04 03:50:23 +02:00
382b182f13 Merge branch 'subrip-1-indexed' of https://projects.blender.org/Alice-Scarlett/blender into subrip-1-indexed
91d15a3613 EEVEE-Next: Fix shader compilation on Metal
5ea561b51c Cleanup: Use Vector and Matrices types in C++
bc3ec100c2 Cleanup: Remove redundant code in Snap To Nearest
f4da74ed29 Revert "Cycles: Make use of maximum concurrent compilations on Metal"
Compare 1629 commits »
Richard Antalik commented on pull request blender/blender#107997 2023-07-04 03:16:27 +02:00
Fix: SubRip subtitle export - sequence numbers now start at 1

Thanks for patch, I have missed notification, sorry about that. The fix seems OK so will merge this. The file has been converted to C++, so will update patch first.

Richard Antalik commented on pull request blender/blender#108877 2023-07-04 03:08:34 +02:00
VSE: Process audio strips waveforms in parallel

@iss I just saw buildbot found a merge conflict here.

Does blender require any special process for this sort of stuff or can I just go ahead and merge master into this branch to sort out…

Richard Antalik suggested changes for blender/blender#108877 2023-07-04 03:03:52 +02:00
VSE: Process audio strips waveforms in parallel

Please use clang-format to format the changes or run make format.

Richard Antalik commented on pull request blender/blender#108877 2023-07-04 03:03:51 +02:00
VSE: Process audio strips waveforms in parallel

Bit of nitpick, but I think the code would be bit more readable:

Richard Antalik commented on pull request blender/blender#108877 2023-07-04 03:03:51 +02:00
VSE: Process audio strips waveforms in parallel

Use BLI_listbase_is_empty(&pj->previews)

Richard Antalik commented on pull request blender/blender#108877 2023-07-04 03:03:50 +02:00
VSE: Process audio strips waveforms in parallel

This variable mirrors PreviewJob::running, so you can use just one of these.

Richard Antalik commented on pull request blender/blender#108877 2023-07-04 03:03:50 +02:00
VSE: Process audio strips waveforms in parallel

This include is not used.

Richard Antalik commented on pull request blender/blender#108877 2023-07-04 03:03:49 +02:00
VSE: Process audio strips waveforms in parallel

I think these conditions could be simplified a bit. I would suggest

Richard Antalik commented on pull request blender/blender#108877 2023-07-04 03:03:49 +02:00
VSE: Process audio strips waveforms in parallel

wm_do_update, wm_progress and are unused in this struct. These can be removed

Richard Antalik commented on pull request blender/blender#108877 2023-07-04 03:03:48 +02:00
VSE: Process audio strips waveforms in parallel

You can use LISTBASE_FOREACH macro here, it's bit less noisy than plain for loop:

Richard Antalik commented on pull request blender/blender#108877 2023-07-04 03:03:48 +02:00
VSE: Process audio strips waveforms in parallel

Foreach macro can be used here too, just use LISTBASE_FOREACH_MUTABLE since you are modifying linked list.