Fix: SubRip subtitle export - sequence numbers now start at 1 #107997

Alice-Scarlett · 2023-05-17T03:37:06+02:00

Alice-Scarlett commented

2023-05-17 03:37:06 +02:00

This PR makes is so when exporting .srt subtitles from the video sequence editor, each subtitle is indexed starting from 1, not 0.

Problem

Currently when exporting subtitles from the VSE, the file generated starts numbering subtitles from 0. Here's an example of the generated .srt file:

0
00:00:00,000 --> 00:00:02,267
Hello world

1
00:00:03,250 --> 00:00:05,533
meow

2
00:00:06,500 --> 00:00:08,783
Goodbye world

While there don't seem to be any official specs for the .srt file format (at least not that I could find), resources online pretty much all start numbering from 1 (Eg: Wikipedia, Matroska, Mailchimp). I ran into this issue trying to import a .srt file into Unreal Engine, where it just failed because it has a check that the first number is 1.

Reproduction steps

Create a project using the Video Editing template
Add a movie strip to the sequencer
Add a few text strips to the sequencer
Use View > Export Subtitles to generate a .srt file
Observe that the .srt file starts numbering at 0

Fix

We start indexing from 1 now - to use the same example as above, now the .srt file generated looks like:

1
00:00:00,000 --> 00:00:02,267
Hello world

2
00:00:03,250 --> 00:00:05,533
meow

3
00:00:06,500 --> 00:00:08,783
Goodbye world

This PR makes is so when exporting .srt subtitles from the video sequence editor, each subtitle is indexed starting from 1, not 0. ## Problem Currently when exporting subtitles from the VSE, the file generated starts numbering subtitles from 0. Here's an example of the generated .srt file: ``` 0 00:00:00,000 --> 00:00:02,267 Hello world 1 00:00:03,250 --> 00:00:05,533 meow 2 00:00:06,500 --> 00:00:08,783 Goodbye world ``` While there don't seem to be any official specs for the .srt file format (at least not that I could find), resources online pretty much all start numbering from 1 (Eg: [Wikipedia](https://en.wikipedia.org/wiki/SubRip#SubRip_file_format), [Matroska](https://www.matroska.org/technical/subtitles.html#srt-subtitles), [Mailchimp](https://mailchimp.com/resources/what-is-an-srt-file/)). I ran into this issue trying to import a .srt file into Unreal Engine, where it just failed because it has a check that the first number is 1. ## Reproduction steps 1. Create a project using the Video Editing template 2. Add a movie strip to the sequencer 3. Add a few text strips to the sequencer 4. Use View > Export Subtitles to generate a .srt file 5. Observe that the .srt file starts numbering at 0 ## Fix We start indexing from 1 now - to use the same example as above, now the .srt file generated looks like: ``` 1 00:00:00,000 --> 00:00:02,267 Hello world 2 00:00:03,250 --> 00:00:05,533 meow 3 00:00:06,500 --> 00:00:08,783 Goodbye world ```

Alice-Scarlett added 1 commit 2023-05-17 03:37:13 +02:00

fdf8797e67 Fix: SubRip subtitle export - sequence numbers now start at 1

While there doesn't seem to be any official specs for the .srt file
format, all resourses I could find online start indexing at 1. This
commit makes Blender's .srt exports start at 1 instead of 0.

Iliya Katushenock added this to the Video Sequencer project 2023-05-17 13:30:59 +02:00

Brecht Van Lommel requested review from Richard Antalik 2023-06-13 19:27:41 +02:00

Richard Antalik commented

2023-07-04 03:16:26 +02:00

Thanks for patch, I have missed notification, sorry about that. The fix seems OK so will merge this.
The file has been converted to C++, so will update patch first.

Thanks for patch, I have missed notification, sorry about that. The fix seems OK so will merge this. The file has been converted to C++, so will update patch first.

👍 1

Richard Antalik approved these changes 2023-07-04 03:34:51 +02:00

Richard Antalik added 1 commit 2023-07-04 03:50:36 +02:00

382b182f13 Merge branch 'subrip-1-indexed' of https://projects.blender.org/Alice-Scarlett/blender into subrip-1-indexed

Richard Antalik merged commit 9cd07da339 into main

2023-07-04 03:55:51 +02:00

Richard Antalik referenced this issue from a commit

2023-07-04 03:55:51 +02:00

Fix VSE subtitle export indexing

Christoph Lendenfeld referenced this issue from a commit

2023-07-06 10:14:59 +02:00

Fix VSE subtitle export indexing