Kaspian Jakobsson kaspian.jakobssongmail.com
0 Followers · 0 Following
  • Joined on 2023-07-04
Repositories
1
 Projects Public Activity Starred Repositories
Kaspian Jakobsson commented on pull request blender/blender#109763 2023-07-31 07:32:07 +02:00
Fix #109679: Normal map strength is applied incorrectly

Hi! Due to an oversight from my part the z-part wasn't actually scaled but that is now remedied following [1]. The noise introduced in the BMW scene was due to not actually scaling the z-normals…

Kaspian Jakobsson pushed to fix-normals at kaspian.jakobsson.../blender 2023-07-31 07:31:55 +02:00
15615bad47 Implemented scaling on the z-axis
61bbfd883f Formatting
995676ae33 Formatting and commenting code
5311419496 Add Cycles and OSL support for tangent normal map fix
65ce55fd29 Fix normals strength from worldspace to tangent space
Compare 6 commits »
Kaspian Jakobsson created branch fix-normals in kaspian.jakobsson.../blender 2023-07-31 07:31:55 +02:00
Kaspian Jakobsson commented on pull request blender/blender#109763 2023-07-25 17:55:20 +02:00
Fix #109679: Normal map strength is applied incorrectly

@brecht

@kaspian.jakobssongmail.com are you looking into a solution for this? Or shall we solve it?

It wasn't immediately obvious to me how best to do it.

I'll take a look at it and…

Kaspian Jakobsson commented on pull request blender/blender#109763 2023-07-13 13:21:22 +02:00
Fix #109679: Normal map strength is applied incorrectly

Misclick with the re-requested review @brecht, sorry!

Thank you for all the reviews and comments! I'll look more into whether a implementation that's only dependent on the last mix of normals…

Kaspian Jakobsson commented on pull request blender/blender#109763 2023-07-08 12:02:27 +02:00
Fix #109679: Normal map strength is applied incorrectly

And here is the setup in cycles and OSL!

Screenshot 2023-07-08 114341.png ![Screenshot 2023-07-08 114259.png](/attachments/f2be4057-b263-4…

Kaspian Jakobsson commented on pull request blender/blender#109763 2023-07-07 22:33:55 +02:00
Fix #109679: Normal map strength is applied incorrectly

@brecht @Alex-R-Heskett you're both entirely right, it looked correct when doing it in world space as well but I think that was a happy coincidence rather than it being correct! :-) My latest…

Kaspian Jakobsson pushed to fix-normals at kaspian.jakobsson.../blender 2023-07-07 22:18:33 +02:00
61bbfd883f Formatting
995676ae33 Formatting and commenting code
5311419496 Add Cycles and OSL support for tangent normal map fix
65ce55fd29 Fix normals strength from worldspace to tangent space
Compare 4 commits »
Kaspian Jakobsson commented on pull request blender/blender#109763 2023-07-06 13:10:19 +02:00
Fix #109679: Normal map strength is applied incorrectly

Thank you for the comments and reviews. I'll update the PR with Cycles and OSL support, and fix the formatting issues when I get home from work.

Also - I'll update this comment with a bit…

Kaspian Jakobsson created pull request blender/blender#109763 2023-07-05 23:55:36 +02:00
Fix #109679: Normal map strength is applied incorrectly
Kaspian Jakobsson created branch fix-normals in kaspian.jakobsson.../blender 2023-07-05 23:36:29 +02:00
Kaspian Jakobsson pushed to fix-normals at kaspian.jakobsson.../blender 2023-07-05 23:36:29 +02:00
8887b519e8 Fix #109679: Normal strength is applied incorrectly
Kaspian Jakobsson deleted branch fix-normals from kaspian.jakobsson.../blender 2023-07-05 23:27:53 +02:00
Kaspian Jakobsson pushed to fix-normals at kaspian.jakobsson.../blender 2023-07-05 23:24:44 +02:00
d6b1b8c2c9 Fixed strength calculations
Kaspian Jakobsson created branch fix-normals in kaspian.jakobsson.../blender 2023-07-05 23:24:43 +02:00
Kaspian Jakobsson deleted branch fix-normals from kaspian.jakobsson.../blender 2023-07-05 23:23:42 +02:00
Kaspian Jakobsson pushed to fix-normals at kaspian.jakobsson.../blender 2023-07-05 23:22:35 +02:00
aacbdab815 Revert "Fixed strength calculations"
Kaspian Jakobsson pushed to fix-normals at kaspian.jakobsson.../blender 2023-07-05 23:20:40 +02:00
f530005f35 Fixed strength calculations
Kaspian Jakobsson created branch fix-normals in kaspian.jakobsson.../blender 2023-07-05 23:20:40 +02:00
Kaspian Jakobsson created repository kaspian.jakobsson.../blender 2023-07-05 23:14:41 +02:00