Laurynas Duburas laurynas
  • Joined on 2021-06-10
Laurynas Duburas commented on pull request blender/blender#120222 2024-04-25 01:08:18 +02:00
Curves: Transform Bezier handles

I have a refactoring idea. It is not total rewrite, but will look better.

Laurynas Duburas commented on pull request blender/blender#120222 2024-04-24 13:10:22 +02:00
Curves: Transform Bezier handles

My main high level comment is that it feels like it may be easier not to put everything into a single position array. It's ok, but I wonder if it could become simpler.

Separate arrays…

Laurynas Duburas pushed to transform-bezier-handles at laurynas/blender 2024-04-24 12:33:47 +02:00
c1441e3c6e return value to append_positions_to_custom_data
Laurynas Duburas pushed to transform-bezier-handles at laurynas/blender 2024-04-24 10:44:36 +02:00
106ce1a2b7 minor refactoring
Laurynas Duburas pushed to transform-bezier-handles at laurynas/blender 2024-04-23 15:26:27 +02:00
9e0e1c5817 layer term removed
Laurynas Duburas pushed to transform-bezier-handles at laurynas/blender 2024-04-23 14:14:05 +02:00
abb03ee61c expand_selected_offsets refactored 2
Laurynas Duburas commented on pull request blender/blender#120222 2024-04-23 13:49:54 +02:00
Curves: Transform Bezier handles

I've refactored expand_selected_offsets. It would be much simpler with proposed iterator, but for now it will do.

Laurynas Duburas commented on pull request blender/blender#120222 2024-04-23 13:45:00 +02:00
Curves: Transform Bezier handles

Agree, it is not.

Laurynas Duburas pushed to transform-bezier-handles at laurynas/blender 2024-04-23 13:43:08 +02:00
df7c4bfab3 expand_selected_offsets refactored
Laurynas Duburas pushed to transform-bezier-handles at laurynas/blender 2024-04-23 12:38:49 +02:00
b24e5ef18b small fixes
Laurynas Duburas commented on pull request blender/blender#120222 2024-04-23 12:26:26 +02:00
Curves: Transform Bezier handles

I doubted about this terminology myself, but it seemed nice in a context where positions from different domains are joined into one flat array. I'll think how to remove it.

Laurynas Duburas commented on pull request blender/blender#120222 2024-04-23 12:20:04 +02:00
Curves: Transform Bezier handles

My main high level comment is that it feels like it may be easier not to put everything into a single position array. It's ok, but I wonder if it could become simpler.

My first impression …

Laurynas Duburas commented on pull request blender/blender#120222 2024-04-23 09:39:22 +02:00
Curves: Transform Bezier handles

I decided to leave Aligned and some other handle type dynamics for another patch.

Laurynas Duburas pushed to transform-bezier-handles at laurynas/blender 2024-04-23 09:22:44 +02:00
5d72d6c556 optimization
fee649010a fixes after merge
Compare 2 commits »
Laurynas Duburas pushed to transform-bezier-handles at laurynas/blender 2024-04-22 23:18:51 +02:00
3c8819d791 Merge branch 'main' into transform-bezier-handles
f1d4859e2a Compositor: implement bicubic spline for CPU compositor
3f6e2ea915 Vulkan: Shader interface access mask
3bddde1b30 Cleanup: update comment regarding blend expand callback
d1f26dad9b Fix #120874: Geometry Nodes: propagate attribute usage through muted node
Compare 537 commits »
Laurynas Duburas pushed to transform-bezier-handles at laurynas/blender 2024-04-22 22:40:42 +02:00
4abcd760af Revert "Implicit sharing problem workaround"
Laurynas Duburas deleted branch transform-data-copy from laurynas/blender 2024-04-22 21:17:21 +02:00
Laurynas Duburas pushed to transform-data-copy at laurynas/blender 2024-04-22 15:13:22 +02:00
be0895ac22 cleanup
Laurynas Duburas pushed to transform-data-copy at laurynas/blender 2024-04-22 14:26:19 +02:00
f2abc80fba Comments added
Laurynas Duburas pushed to transform-data-copy at laurynas/blender 2024-04-20 09:07:03 +02:00
20f94e5865 cleanup