Laurynas Duburas laurynas
  • Joined on 2021-06-10
Laurynas Duburas pushed to custom_nurbs_knots at laurynas/blender 2024-11-22 15:07:02 +01:00
3fac4761af Merge branch 'main' into custom_nurbs_knots
cc61ab4dbd Refactor: Curves: Various changes to extrude operator
076e1150fc Fix #130720: Crash when saving blend file
01af6ffd22 Compositor: Implement Blur node for new CPU compositor
986802fc87 Composite: Implement Van Vliet Gaussian blur for CPU
Compare 429 commits »
Laurynas Duburas deleted branch refactor_curves_extrude from laurynas/blender 2024-11-22 14:38:11 +01:00
Laurynas Duburas pushed to refactor_curves_extrude at laurynas/blender 2024-11-20 15:12:38 +01:00
92f37d4b1d small optimization
Laurynas Duburas commented on pull request blender/blender#130229 2024-11-20 13:56:52 +01:00
Refactor: Curves: Various changes to extrude operator

@HooglyBoogly Once again it is finished :) Sometimes I regret starting this refactoring, but extrude has improved.

Laurynas Duburas pushed to refactor_curves_extrude at laurynas/blender 2024-11-20 13:48:21 +01:00
0362854849 finish_curve_or_full_copy to handle_curves_preceding
Laurynas Duburas commented on pull request blender/blender#130229 2024-11-18 22:08:28 +01:00
Refactor: Curves: Various changes to extrude operator

I think it would be more difficult to implement with masks. For ex. if selection range crosses boundary of two curves, the range needs to be split into two and each handled separately depending…

Laurynas Duburas commented on pull request blender/blender#130229 2024-11-18 21:30:53 +01:00
Refactor: Curves: Various changes to extrude operator

Ouch, thought it was different place. :) I had those stated considerations earlier.

I don't know it is static function, most likely will not be used anywhere else. I don't feel very…

Laurynas Duburas pushed to refactor_curves_extrude at laurynas/blender 2024-11-18 21:22:47 +01:00
08fdfbaff0 drop_front
Laurynas Duburas commented on pull request blender/blender#130229 2024-11-18 21:21:51 +01:00
Refactor: Curves: Various changes to extrude operator

Everything would work without compress_intervals. With it I try to minimize copy_assign_n per each attribute. So creating an extra buffer would undermine the purpose of the function itself.

Laurynas Duburas commented on pull request blender/blender#130229 2024-11-18 21:15:37 +01:00
Refactor: Curves: Various changes to extrude operator

It is too messy if to handle without points_by_curve cut because extrusion behaves differently at endpoints of curves. It is possible to keep unmodified curves in groups and modified one by one.…

Laurynas Duburas commented on pull request blender/blender#130229 2024-11-18 20:12:30 +01:00
Refactor: Curves: Various changes to extrude operator

Okay that's alright! Just let me know when it's ready for another look.

Done.

Laurynas Duburas pushed to refactor_curves_extrude at laurynas/blender 2024-11-18 20:08:23 +01:00
a2b38b33ee shift_end_by separate function
6f0b953379 extend_back renamed to shift_end_by
Compare 2 commits »
Laurynas Duburas commented on pull request blender/blender#130229 2024-11-18 17:47:42 +01:00
Refactor: Curves: Various changes to extrude operator

Indeed, I misread it. Empty IndexRange extending is needed here. For copy_intervals I use OffsetIndices a bit behind specification, as it states "ascending indices". Here they are…

Laurynas Duburas commented on pull request blender/blender#130229 2024-11-18 14:59:43 +01:00
Refactor: Curves: Various changes to extrude operator

@JacquesLucke what do I do?

Laurynas Duburas pushed to refactor_curves_extrude at laurynas/blender 2024-11-18 14:39:35 +01:00
927e14cda2 move single point extrusion to handle_range and remove redundant variables
eb2a93cd44 revert calc_curves_extrusion
Compare 2 commits »
Laurynas Duburas commented on pull request blender/blender#130229 2024-11-16 22:03:38 +01:00
Refactor: Curves: Various changes to extrude operator

@HooglyBoogly if you didn't start looking and this rewrite I want to switch back to old version with a bit more clean up. Sorry for tossing around. The idea how to view things came only after…

Laurynas Duburas commented on pull request blender/blender#130229 2024-11-15 19:00:23 +01:00
Refactor: Curves: Various changes to extrude operator

I'd prefer to allow negatives. This would allow to avoid extra if when situation requires both expanding and shrinking. Regarding assert overall, constructor hasBLI_assert(size >= 0); if…

Laurynas Duburas pushed to refactor_curves_extrude at laurynas/blender 2024-11-15 12:01:25 +01:00
fa3b043063 cleanup
Laurynas Duburas commented on pull request blender/blender#130229 2024-11-15 11:23:07 +01:00
Refactor: Curves: Various changes to extrude operator

I rewrote calc_curves_extrusion. Signature stays the same, but approach is different. The idea is to collect selection range indexes into an array and then merge it with a curves endpoint…

Laurynas Duburas pushed to refactor_curves_extrude at laurynas/blender 2024-11-15 11:05:46 +01:00
90b34b32c0 comment fix