William Leeson leesonw
  • Joined on 2021-06-09
William Leeson commented on issue blender/blender#125047 2024-07-19 09:03:54 +02:00
Shadow paths are always compacted

Thanks. Looks like I had put in the code for the fix and not the bug so I updated the pasted code. So now maybe it is easier to understand.

William Leeson commented on issue blender/blender#125047 2024-07-19 08:59:39 +02:00
Shadow paths are always compacted

I have a fix for this in #125048

William Leeson commented on pull request blender/blender#125048 2024-07-19 08:49:21 +02:00
FIX: only compact if index is a ratio of the number of paths

This is a fix for #125047

William Leeson created pull request blender/blender#125048 2024-07-19 08:37:27 +02:00
FIX: only compact if index is a ratio of the number of paths
William Leeson opened issue blender/blender#125047 2024-07-19 08:35:56 +02:00
Shadow paths are always compacted
William Leeson pushed to fix-compact-shadow-paths at leesonw/blender-cluster 2024-07-19 08:30:59 +02:00
b9f3d8d72c FIX: only compact if index is a ratio of the number of paths
cee4ad4518 Refactor: Cycles: oneAPI: Simplify num_concurrent_states()
c8421a0007 Cycles: set num_sort_partition_elements to 65536 for simd16+ Intel GPUs
9a28e1d1b8 Refactor: move fcurve methods from KeyframeStrip to ChannelBag
52ad896b35 Fix: Outliner: incorrect tooltip for delete library operator
Compare 10 commits »
William Leeson created branch fix-compact-shadow-paths in leesonw/blender-cluster 2024-07-19 08:30:59 +02:00
William Leeson commented on pull request blender/blender#123056 2024-06-11 16:14:16 +02:00
Fix: Crash and or assert in mesh index buffer creation

Thanks all merged now :-)

William Leeson deleted branch fix-ibo-lines from leesonw/blender-cluster 2024-06-11 16:13:41 +02:00
William Leeson pushed to main at blender/blender 2024-06-11 16:13:40 +02:00
81d5af15a6 Fix: Crash and or assert in mesh index buffer creation
William Leeson merged pull request blender/blender#123056 2024-06-11 16:13:38 +02:00
Fix: Crash and or assert in mesh index buffer creation
William Leeson commented on pull request blender/blender#123056 2024-06-11 15:56:41 +02:00
Fix: Crash and or assert in mesh index buffer creation

Ran make format and resubmitted extract_mesh_ibo_points.cc

William Leeson pushed to fix-ibo-lines at leesonw/blender-cluster 2024-06-11 15:54:41 +02:00
a1fde51709 Fix formatting
William Leeson commented on pull request blender/blender#123056 2024-06-11 15:31:37 +02:00
Fix: Crash and or assert in mesh index buffer creation

Thanks! The same change probably makes sense in extract_points_mesh.

I applied the change to extract_points_mesh

William Leeson commented on pull request blender/blender#123056 2024-06-11 15:30:32 +02:00
Fix: Crash and or assert in mesh index buffer creation

I renamed mapping to vbo_index

William Leeson pushed to fix-ibo-lines at leesonw/blender-cluster 2024-06-11 15:29:54 +02:00
6364c61ed6 FIX:Reuse the index instead of rereading it from the map
9adb29bf14 Rename mapping to index.
Compare 2 commits »
William Leeson commented on pull request blender/blender#123056 2024-06-11 14:50:54 +02:00
Fix: Crash and or assert in mesh index buffer creation

Yes, exactly the longer you wait the more likely that another thread will start working on this.

William Leeson created pull request blender/blender#123056 2024-06-11 09:12:49 +02:00
While debugging Blender I frequently encountered a crash and or assert in the extract_mesh_lines function.
William Leeson pushed to fix-ibo-lines at leesonw/blender-cluster 2024-06-11 09:09:13 +02:00
7eb6c51355 Reformat code
William Leeson pushed to fix-ibo-lines at leesonw/blender-cluster 2024-06-11 09:07:54 +02:00
af35f72fff FIX: Read mapping once to fix invalid value later
69e520627f Anim: reset idroot when adding a layer or binding to an Action
25d2e905b2 Merge branch 'blender-v4.2-release'
65f68fe7fe BPY IDProp tests: Add basic tests for 'UI data' system.
3c01ff0824 Anim: Bump subversion to 1 for 'generated' keytype theme versioning
Compare 10 commits »