Loren Osborn linux_dr
  • Joined on 2015-06-09
32ab195379 added enforcement of autopep8 settings
Loren Osborn created branch losborn_PR5_FIXUP_scale in linux_dr/add_mesh_BoltFactory 2024-08-15 02:27:00 +02:00
Loren Osborn pushed to losborn_PR5_FIXUP_scale at linux_dr/add_mesh_BoltFactory 2024-08-15 02:27:00 +02:00
a2241a2dcd Proposed fixes to 'Incorrect scale of created bolts'
Loren Osborn created branch losborn_ISSUE8_missing_presets in linux_dr/add_mesh_BoltFactory 2024-08-15 02:26:03 +02:00
dee80f5937 Proposed fixes to 'Operator Presets don't exists from Release 4.2'
Loren Osborn commented on issue extensions/add_mesh_BoltFactory#8 2024-08-12 03:34:44 +02:00
Operator Presets don't exists from Release 4.2

I have a fix for the scale of the presets on the pre-4.2 code locally, but haven’t tested it yet. I haven’t looked into updating this here yet. I’ll keep you posted.

Loren Osborn commented on issue extensions/add_mesh_BoltFactory#6 2024-08-12 02:21:39 +02:00
Incorrect bolt sizes BoltFactory add-on

@sw-tya, It looks like you have a good handle on this. I look forward to seeing your PR for it.

Loren Osborn commented on pull request blender/blender-addons#105397 2024-08-10 07:59:03 +02:00
Fix #83322: Scale factor issue

Modifying the inputs to include an angle as one of the inputs was part of a larger change I was working on, but turned out to be more involved, so I hadn't planned on backporting that part. I…

Loren Osborn commented on pull request blender/blender-addons#105397 2024-08-09 20:01:23 +02:00
Fix #83322: Scale factor issue

(Actually commenting on 268-281)

Loren Osborn commented on pull request blender/blender-addons#105397 2024-08-09 19:58:04 +02:00
Fix #83322: Scale factor issue

The preset values that are stored in the folder /addons/presets/operator/mesh.bolt_add are inputting values into the dialog box using mm rather than m. This means that the change presented…

Loren Osborn commented on pull request blender/blender-addons#105397 2024-08-09 19:41:54 +02:00
Fix #83322: Scale factor issue

This is a great reference, and I may actually use it in further enhancements I began working on.

I do think we should definitely support up to M160 or 160 mm, but I am hesitant to make this a…

Loren Osborn commented on pull request blender/blender-addons#105397 2024-08-09 19:33:12 +02:00
Fix #83322: Scale factor issue

I searched for all props that already had division by GLOBAL_SCALE somewhere in the file with the following regex:

bf_(12_Point_(Head
Loren Osborn commented on pull request blender/blender-addons#105397 2024-08-07 23:25:44 +02:00
Fix #83322: Scale factor issue

Practically 250 would be a better limit as that would cover anything that I have seen in agriculture.

Looking at the drivel on Wikipedia I got a bit bored and resorted to ChatGPT which said…

Loren Osborn commented on issue extensions/add_mesh_BoltFactory#6 2024-08-07 20:40:05 +02:00
Incorrect bolt sizes BoltFactory add-on

I hope to review this within 48 hours

Loren Osborn commented on pull request blender/blender-addons#105397 2024-08-07 20:32:43 +02:00
Fix #83322: Scale factor issue

@lichtwerk, yes, I saw #84782, agreed it would be included in fix-set, but somehow let it fall on the floor. My mistake. Good catch.

Been a busy week here, possibly won’t get to review this…

Loren Osborn pushed to main at linux_dr/add_mesh_BoltFactory 2024-07-18 05:06:23 +02:00
05b556a2ae Fix #5: Scale factor issue (#7)
Loren Osborn commented on pull request blender/blender-addons#105397 2024-07-17 19:49:38 +02:00
Fix #83322: Scale factor issue

@nickberckley suggested that this should be considered for #LTS36

(@brecht, ChatGPT seems to think that you’re Primary Person Responsible for 3.6 LTS maintenance, so I’m tagging you in this…

Loren Osborn commented on issue blender/blender-addons#83322 2024-07-17 19:13:34 +02:00
Incorrect scale of created bolts.

I didn’t even think of 3.6… good catch… I was just wanting to address the overall issue count. Who is the 3.6 LTS maintainer so we can bring this to their attention?

Loren Osborn commented on issue blender/blender-addons#83322 2024-07-17 16:58:59 +02:00
Incorrect scale of created bolts.

@nickberckley, what should happen to these two issues now that they are addressed in the other repo?