Loren Osborn linux_dr
  • Joined on 2015-06-09
Loren Osborn commented on pull request extensions/add_mesh_BoltFactory#11 2024-08-24 18:04:38 +02:00
Fix for #8 'Operator Presets don't exists from Release 4.2'

Is there a reason this isn't closed yet? Is someone waiting on me to do something?

Loren Osborn commented on pull request extensions/add_mesh_BoltFactory#12 2024-08-21 20:38:22 +02:00
Fix for #1: Countersink Head angle vs nominal size

I made changes and tried to update this but can't:

/add_mesh_BoltFactory$ git push me swtya_CounterSinkHead To projects.blender.org:sw-tya/add_mesh_BoltFactory.git ` !…

Loren Osborn commented on pull request extensions/add_mesh_BoltFactory#11 2024-08-20 20:25:53 +02:00
Fix for #8 'Operator Presets don't exists from Release 4.2'

@sw-tya wrote:

4.2 is not any worse, that's still awaiting the directory search backport.

could you edit this comment to make it something like:

~~4.2 is not any worse, that's still…

f2d3ab9487 added enforcement of autopep8 settings
e18daa282e Proposed fixes to 'Operator Presets don't exists from Release 4.2'
59166a8be8 Proposed fixes to 'Incorrect scale of created bolts' (#10)
Compare 3 commits »
Loren Osborn pushed to main at linux_dr/add_mesh_BoltFactory 2024-08-20 20:14:39 +02:00
59166a8be8 Proposed fixes to 'Incorrect scale of created bolts' (#10)
Loren Osborn commented on pull request extensions/add_mesh_BoltFactory#11 2024-08-20 19:24:58 +02:00
Fix for #8 'Operator Presets don't exists from Release 4.2'

@nickberckley wrote:

@linux_dr can you merge main in this PR branch?

I have no permissions to merge any PRs. If someone wants to grant me such permissions we can stop asking you.

Also…

Loren Osborn commented on pull request extensions/add_mesh_BoltFactory#13 2024-08-20 06:09:01 +02:00
Fix for #6: Incorrect bolt lengths

I will review this when I can, but I still wanted to thank you for your contributions! 🎉

Loren Osborn commented on pull request extensions/add_mesh_BoltFactory#12 2024-08-19 20:22:42 +02:00
Fix for #1: Countersink Head angle vs nominal size

If you’re in a hurry, you could simply branch off swtya_combinedFixes_PR10_and_PR11 (git checkout swtya_combinedFixes_PR10_and_PR11 ;git checkout -b {new_branch_name_here} ), and cherry-pick…

Loren Osborn reopened issue extensions/add_mesh_BoltFactory#1 2024-08-19 15:11:33 +02:00
Bolt Factory Addon: Incorrect countersink angle & head size in Create_CounterSink_Head()
Loren Osborn closed issue extensions/add_mesh_BoltFactory#1 2024-08-19 15:10:33 +02:00
Bolt Factory Addon: Incorrect countersink angle & head size in Create_CounterSink_Head()
Loren Osborn commented on pull request extensions/add_mesh_BoltFactory#12 2024-08-19 07:35:44 +02:00
Fix for #1: Countersink Head angle vs nominal size

I certainly applaud your research and initiative, but my concern is “the best thing about standards is there are so many to choose from.” Would there be a reason this couldn’t be an additional parameter in the GUI? I would love if the default value changed according to the shank diameter, but I expect other standards bodies will declare other counter sink angles in their own ecosystems.

Loren Osborn commented on issue extensions/add_mesh_BoltFactory#1 2024-08-19 06:33:07 +02:00
Bolt Factory Addon: Incorrect countersink angle & head size in Create_CounterSink_Head()

The pull/12 should address …

Congrats on your second PR… I will look at it ASAP, but wanted to mention that typing #12 in a comment should generate a link to it

Loren Osborn commented on pull request extensions/add_mesh_BoltFactory#11 2024-08-17 04:36:43 +02:00
Fix for #8 'Operator Presets don't exists from Release 4.2'

@nickberckley, this should be ready to rebase and merge after #10

Loren Osborn commented on pull request extensions/add_mesh_BoltFactory#10 2024-08-17 04:35:29 +02:00
Proposed fixes to 'Incorrect scale of created bolts'

@nickberckley, this should be ready to merge.

Loren Osborn commented on pull request extensions/add_mesh_BoltFactory#11 2024-08-17 04:28:14 +02:00
Fix for #8 'Operator Presets don't exists from Release 4.2'

@sw-tya wrote:

…, that's still awaiting the directory search backport. 4.3 works correctly.

I don’t know anything about this directory search feature you mentioned. Can you please…

Loren Osborn commented on pull request extensions/add_mesh_BoltFactory#11 2024-08-16 03:33:38 +02:00
Fix for #8 'Operator Presets don't exists from Release 4.2'

Yes, good catch. I hadn't realized that I had separated out the change from IntProperty to FloatProperty from the change of 10 to 12.5 in the presets, but I obviously had. I would not do a…

Loren Osborn commented on pull request extensions/add_mesh_BoltFactory#10 2024-08-16 02:49:04 +02:00
Proposed fixes to 'Incorrect scale of created bolts'

@sw-tya, thank you for your quick review

Loren Osborn created pull request extensions/add_mesh_BoltFactory#11 2024-08-15 02:56:47 +02:00
losborn_ISSUE8_missing_presets
Loren Osborn created pull request extensions/add_mesh_BoltFactory#10 2024-08-15 02:54:30 +02:00
Proposed fixes to 'Incorrect scale of created bolts'