extensions/add_mesh_BoltFactory
1
1
Fork 3
Code Issues 5 Pull Requests 3 Projects Releases Wiki Activity

Proposed fixes to 'Incorrect scale of created bolts' #10

Merged
Nika Kutsniashvili merged 1 commits from linux_dr/add_mesh_BoltFactory:losborn_PR5_FIXUP_scale into main 2024-08-20 16:24:27 +02:00
Conversation 2 Commits 1 Files Changed 2 +7 -7
Loren Osborn commented 2024-08-15 02:54:28 +02:00
Contributor
Copy Link

@sw-tya found several issues I had missed with #7. I addressed most of them here.

The issue of missing presets is a seperate issue, and will be addressed in a separate PR here

  • The bolt diameter was artificially limited to 50 mm. Has been changed to 250 mm
  • The "crest" and "root" of the threads had been expressed as an integer percentage, defaulting to 10. This has been changed to a float percentage and the standard thread values of 25% and 12.5% are the new defaults.
  • The "Cap" and "Countersink" heads didn't correctly divide by GLOBAL_SCALE to account for the new scaling fix, so ended up pinched off below the screw head.
@sw-tya found several issues I had missed with https://projects.blender.org/extensions/add_mesh_BoltFactory/pulls/7. I addressed most of them here. The issue of missing presets is a seperate issue, and will be addressed in a separate PR [here](https://projects.blender.org/extensions/add_mesh_BoltFactory/pulls/11) - The bolt diameter was artificially limited to 50 mm. Has been changed to 250 mm - The "crest" and "root" of the threads had been expressed as an integer percentage, defaulting to 10. This has been changed to a float percentage and the standard thread values of 25% and 12.5% are the new defaults. - The "Cap" and "Countersink" heads didn't correctly divide by `GLOBAL_SCALE` to account for the new scaling fix, so ended up pinched off below the screw head.
Loren Osborn added 1 commit 2024-08-15 02:54:29 +02:00 
#5
sw-tya approved these changes 2024-08-16 02:04:11 +02:00
sw-tya left a comment
First-time contributor
Copy Link

I'm happy with these changes. Thanks

I'm happy with these changes. Thanks
👍 1
Loren Osborn commented 2024-08-16 02:49:04 +02:00
Author
Contributor
Copy Link

@sw-tya, thank you for your quick review

@sw-tya, thank you for your quick review
Loren Osborn commented 2024-08-17 04:35:29 +02:00
Author
Contributor
Copy Link

@nickberckley, this should be ready to merge.

@nickberckley, this should be ready to merge.
Nika Kutsniashvili merged commit 59166a8be8 into main 2024-08-20 16:24:27 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
sw-tya
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: extensions/add_mesh_BoltFactory#10
No description provided.
Delete Branch "linux_dr/add_mesh_BoltFactory:losborn_PR5_FIXUP_scale"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?