extensions/add_mesh_BoltFactory
1
1
Fork 4
Code Issues 5 Pull Requests 2 Projects Releases Wiki Activity

Fix #5: Scale factor issue #7

Merged
Nika Kutsniashvili merged 2 commits from linux_dr/add_mesh_BoltFactory:losborn_issue83322_fix into main 2024-07-17 13:24:00 +02:00
Conversation 4 Commits 2 Files Changed 4 +554 -558
Loren Osborn commented 2024-07-16 20:32:13 +02:00
Contributor
Copy Link

Ported blender/blender-addons#105397 to new repository:

Fix for issue #5:
Should also address #3
(previously blender/blender-addons#83322 and blender/blender-addons#84782 respectively)

  • BoltFactory was written with 1mm Blender Units in mind (Blender units are now officially 1m)
  • Addon already suppoted GLOBAL_SCALE constant, but assumed inputs would always be in millimeters.
  • Since input fields now show units (that are incorrect here) the input field units needed to be converted to Blender units first.
  • Then converted back to millimeters when constructing the mesh.
  • Then let the addon scale the result as it expected.
Ported https://projects.blender.org/blender/blender-addons/pulls/105397 to new repository: Fix for issue #5: Should also address #3 (previously https://projects.blender.org/blender/blender-addons/issues/83322 and https://projects.blender.org/blender/blender-addons/issues/84782 respectively) - BoltFactory was written with 1mm Blender Units in mind (Blender units are now officially 1m) - Addon already suppoted GLOBAL_SCALE constant, but assumed inputs would always be in millimeters. - Since input fields now show units (that are incorrect here) the input field units needed to be converted to Blender units first. - Then converted back to millimeters when constructing the mesh. - Then let the addon scale the result as it expected.
Loren Osborn added 2 commits 2024-07-16 20:32:15 +02:00 
* BoltFactory was written with 1mm Blender Units in mind (Blender
    units are now officially 1m)
* Addon already suppoted `GLOBAL_SCALE` constant, but assumed
    inputs would always be in millimeters.
* Since input fields now show units (that are incorrect here)
    the input field units needed to be converted to Blender units first.
* Then converted back to millimeters when constructing the mesh.
* Then let the addon scale the result as it expected.
Nika Kutsniashvili commented 2024-07-17 13:23:21 +02:00
Owner
Copy Link

Looks like copying files across changed formatting quite a bit, but I'll allow this since it's not a meaningful change and no one else is maintaining it to have strong opinions about formatting.

Looks like copying files across changed formatting quite a bit, but I'll allow this since it's not a meaningful change and no one else is maintaining it to have strong opinions about formatting.
Nika Kutsniashvili approved these changes 2024-07-17 13:23:44 +02:00
Nika Kutsniashvili merged commit 05b556a2ae into main 2024-07-17 13:24:00 +02:00
Loren Osborn commented 2024-07-17 16:46:12 +02:00
Author
Contributor
Copy Link

Looks like copying files across changed formatting quite a bit, but I'll allow this since it's not a meaningful change and no one else is maintaining it to have strong opinions about formatting.

Thank you for your quick review, especially in light of the LTS yesterday.

I admit the formatting changes should have been a separate PR; that’s why I left them as a distinct commit, (not realizing that it would automatically be squashed)

As part of copying the files over, @ideasman42 added pyproject.toml in commit 42a2c04644 “2 months ago”. That is the configuration file for the code formatted, and the code formatting should have been added then. I thought it was valuable to be consistent with the config file, so I added the code formatting fixes to this PR.

Thanks again for the quick turn around.

> Looks like copying files across changed formatting quite a bit, but I'll allow this since it's not a meaningful change and no one else is maintaining it to have strong opinions about formatting. Thank you for your quick review, especially in light of the LTS yesterday. I admit the formatting changes should have been a separate PR; that’s why I left them as a distinct commit, (not realizing that it would automatically be squashed) As part of copying the files over, @ideasman42 added `pyproject.toml` in commit 42a2c04644fe43e92189665e08ca7e22c2ce5d3e “2 months ago”. That is the configuration file for the code formatted, and the code formatting should have been added then. I thought it was valuable to be consistent with the config file, so I added the code formatting fixes to this PR. Thanks again for the quick turn around.
sw-tya commented 2024-08-05 23:36:51 +02:00
First-time contributor
Copy Link

Thanks for taking the time to port this extension and fix into the new extensions programme.
The cap head bolt "props.bf_Shank_Dia" is missing the Global Scale in line 2400.

Thanks for taking the time to port this extension and fix into the new extensions programme. The cap head bolt "props.bf_Shank_Dia" is missing the Global Scale in line 2400.
sw-tya commented 2024-08-08 16:32:34 +02:00
First-time contributor
Copy Link

I think this commit has caused my:
blender/blender-addons#105083
to become obsolete. I'll see if I can figure out how to expunge that.

I think this commit has caused my: https://projects.blender.org/blender/blender-addons/pulls/105083 to become obsolete. I'll see if I can figure out how to expunge that.
Sign in to join this conversation.
Reviewers
No reviewers
Nika Kutsniashvili
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: extensions/add_mesh_BoltFactory#7
No description provided.
Delete Branch "linux_dr/add_mesh_BoltFactory:losborn_issue83322_fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?